chore: use starlette built-in Route class #2267
Conversation
leseb
requested review from
ashwinb,
yanxi0830,
hardikjshah,
raghotham,
ehhuang,
terrytangyuan and
bbrowning
as code owners
facebook-github-bot
added
the
CLA Signed
leseb
force-pushed
the
mv-endpoint-baseroute
branch
from
4b994e5 to
5a6cb56
Compare
| route=e.route, | ||
| method=e.method, | ||
| route=e.path, | ||
| method=next(iter([m for m in e.methods if m != "HEAD"])), |
There was a problem hiding this comment.
this is confusing, why is this needeed?
There was a problem hiding this comment.
because fastapi adds "HEAD" in methods if the method is GET :/
leseb
force-pushed
the
mv-endpoint-baseroute
branch
from
5a6cb56 to
78ea523
Compare
|
|
||
| from pydantic import BaseModel | ||
| from aiohttp import hdrs |
There was a problem hiding this comment.
I don't know what this gets us. GET / POST / DELETE is straightforward enough
There was a problem hiding this comment.
Well, most constants are straightforward 😅
leseb
force-pushed
the
mv-endpoint-baseroute
branch
from
78ea523 to
d584007
Compare
|
arrrrghh this |
yess, I hate it. I am pretty sure I am doing something wrong here. Do you have the full stack trace? Let's fix this goddammit. |
Opened this earlier #2278 |
leseb
force-pushed
the
mv-endpoint-baseroute
branch
2 times, most recently
from
393348d to
fddd58e
Compare
Use a more common pattern and known terminology from the ecosystem, where Route is more approved than Endpoint. Signed-off-by: Sébastien Han <[email protected]>
leseb
force-pushed
the
mv-endpoint-baseroute
branch
from
fddd58e to
9472c10
Compare
What does this PR do?
Use a more common pattern and known terminology from the ecosystem, where Route is more approved than Endpoint.