Optimize performance for large-scale parallelism #122
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses performance bottlenecks in multithreaded scenarios by refactoring how Regex objects are handled.
The crate currently uses a globally shared Regex object, which internally maintains a cache pool. This implementation causes significant contention overhead when accessed by multiple threads simultaneously.
This PR changes Regex objects from global to thread-local storage. Each thread now compiles its own Regex upon first access and maintains an independent cache. We also add a new multithreaded benchmark to demonstrate the impact.
On a 11-core Macbook M3 Pro:
On a 192-core x86_64 server:
Tips: Hide whitespace for better review experience