protobuf: do not use symlinks #2212
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symlinks on Windows can be problematic. This PR replaces them with simple copies.
To make this change, it would be useful to know what even is the purpose of the symlink:
wrapdb/subprojects/packagefiles/protobuf/src/meson.build
Lines 2 to 11 in 92719d5
The wrap builds without it (and with all
proto_includes_link_dep
dependencies removed). If there is some elegant way to remove this entirely, it should be preferred.What is the purpose of the symlink?