Skip to content

protobuf: do not use symlinks #2212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

meator
Copy link
Contributor

@meator meator commented Jun 21, 2025

Symlinks on Windows can be problematic. This PR replaces them with simple copies.

To make this change, it would be useful to know what even is the purpose of the symlink:

python = find_program('python3')
proto_includes_link = custom_target(
'proto_includes_link',
input: files('symlink.py'),
output: 'include', # directory adjacent to protoc binary
command: [python, '@INPUT@', meson.current_source_dir(), '@OUTPUT@'],
)
proto_includes_link_dep = declare_dependency(
sources: proto_includes_link,
)

The wrap builds without it (and with all proto_includes_link_dep dependencies removed). If there is some elegant way to remove this entirely, it should be preferred.

What is the purpose of the symlink?

@meator
Copy link
Contributor Author

meator commented Jun 21, 2025

CI failure is not caused by this PR.

@bgilbert
Copy link
Collaborator

It was added in #1263 to address #1259.

@bgilbert
Copy link
Collaborator

Why not copy on Windows and symlink otherwise?

@meator meator force-pushed the protobuf branch 2 times, most recently from 23bd939 to 13114ec Compare June 23, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants