Internal IR for compiler args #14748
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal is to be able to convert arguments from raw arguments that are passed in via the `c_args` and friends methods, as well as from options and the environment, into an abstract IR. This IR is then passed around internally, and the backend is responsible for lowering it into the format that it wants. I'm hoping that this will simplify some amount of passing arguments between languages (like C arguments being passed to non-c compilers, and linker arguments between languages) as well as simplify the non-ninja backends which generally use a different mechanism than raw compiler arguments.
…arguments These will be used to convert the arguments in many cases.
|
FWIW, I like this! |
dnicolodi
reviewed
Jun 27, 2025
| :param enable: If true then enable the warning, otherwise suppress it. | ||
| """ | ||
|
|
||
| target: str |
There was a problem hiding this comment.
I think an enable member went missing here.
dnicolodi
reviewed
Jun 27, 2025
| elif arg.startswith('-U'): | ||
| ret.append(arguments.Undefine(arg.removeprefix('-U'))) | ||
| elif arg.startswith('-Wno-'): | ||
| ret.append(arguments.Warning(arg.removeprefix('-Wno-'), False)) |
There was a problem hiding this comment.
Handling of arguments starting with -Wno- is duplicated below.
dnicolodi
reviewed
Jun 27, 2025
|
|
||
| for arg in args: | ||
| match arg: | ||
| case arguments.Define(name, value): |
There was a problem hiding this comment.
Shouldn't this be case arguments.Define(name, None)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is set to draft because it's very much a Work in Progress.
The way we handle compiler arguments in Meson is to manipulate raw strings. This works fine when the majority of your compilers are the same, or at least attempt to be compatible. Unfortunately, Meson has to deal with many different toolchains, which often have incompatible argument syntax.
This manifests in a number of different ways:
-Wl,-rlinkor-rlinkinside ofbuild.py, but that could miss-rlinkfor many compilers.ifblocks converting string command line arguments to XML fieldsIn order to address this I propose moving to an abstract IR for these arguments. This abstract IR would simplify de-duplicating and cleaning arguments, as well as converting their forms. Each Compiler provides a mechanism to convert arguments from their format into the abstract IR, and a method to convert the abstract IR back into concrete arguments in their expected format. We then manipulate the abstract IR more easily. Consider something like this:
In this format it's pretty easy to look and see that we have two copies of
-DXand two copies of-Wfooalong with-Wno-foo, cancelling both of those out.Below is a very trivial implementation of this idea, with just enough implemented for GCC or Clang to compile the
1 trivialtest (run directly). This also is making use of python features we currently cant rely on, I'll rewrite those later.