Skip to content

Fix: duplicate file and component processing during mesheryctl registry generate #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

souvikinator
Copy link
Contributor

@souvikinator souvikinator commented Feb 5, 2025

Description

This PR fixes #

  1. Moved common method ProcessContent in url.go and git_repo.go to utils
  2. Fix: duplicate file and component processing
  3. Incorporated ProcessContent utils with url.go and git_repo.go
  4. Add extra context to ConvertToK8Manifest

Context:
Happens while running mesheryctl registry generate

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Souvik Kar Mahapatra <[email protected]>
2. fix: duplicate file and component processing
3. Incorporated ProcessContent utils with url.go and git_repo.go
4. Add extra context to ConvertToK8Manifest

Signed-off-by: Souvik Kar Mahapatra <[email protected]>
@souvikinator souvikinator changed the title Souvik/fix/duplicate component and file processing Fix: duplicate file and component processing during mesheryctl registry generate Feb 5, 2025
@leecalcote
Copy link
Member

@riyaa14 @souvikinator is this PR still relevant?

Copy link

stale bot commented Apr 10, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Apr 10, 2025
Copy link

stale bot commented Apr 22, 2025

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/stale Issue has not had any activity for an extended period of time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants