Skip to content

[CI] Update e2e-test.yaml #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2025
Merged

[CI] Update e2e-test.yaml #120

merged 1 commit into from
Apr 20, 2025

Conversation

leecalcote
Copy link
Member

Notes for Reviewers

This PR adds:

  1. manual workflow dispatch with optional input for helm chart version
  2. externalizes helm chart value (for manually dispatched workflows) with default helm chart version.

Signed commits

  • Yes, I signed my commits.

@github-actions github-actions bot added the area/ci Continuous integration | Build and release label Apr 20, 2025
@leecalcote leecalcote requested a review from Aijeyomah April 20, 2025 11:02
theBeginner86
theBeginner86 approved these changes Apr 20, 2025
View reviewed changes
Copy link
Member

@theBeginner86 theBeginner86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

LGTM

@theBeginner86 theBeginner86 merged commit 56dfcd0 into master Apr 20, 2025
3 of 4 checks passed
@theBeginner86 theBeginner86 deleted the leecalcote-patch-3 branch April 20, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aijeyomah Aijeyomah Aijeyomah approved these changes

@theBeginner86 theBeginner86 theBeginner86 approved these changes

Assignees
No one assigned
Labels
area/ci Continuous integration | Build and release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leecalcote @Aijeyomah @theBeginner86