-
Notifications
You must be signed in to change notification settings - Fork 17
update kanvas snapshot version #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update kanvas snapshot version #111
Conversation
Signed-off-by: Eti Ijeoma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
You might want to incorporate an update to https://github.com/meshery-extensions/helm-kanvas-snapshot/blob/master/plugin.yaml#L2 as well?
Considering a new release would be required for this plugin.
Great suggestion! |
I opened a PR with a plugin version update (for this release) and an issue for future enhancement. |
Thank you, @ritzorama. This is precisely what we discussed. This is helpful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gooood! :smiling
Notes for Reviewers
This PR fixes #
Signed commits