Skip to content

update kanvas snapshot version #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Aijeyomah
Copy link
Contributor

Notes for Reviewers

This PR fixes #

  • Bumps Kanvas GitHub Action to the latest version to enable email sending functionality

Signed commits

  • Yes, I signed my commits.

@Aijeyomah Aijeyomah self-assigned this Apr 12, 2025
Copy link
Member

@theBeginner86 theBeginner86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

You might want to incorporate an update to https://github.com/meshery-extensions/helm-kanvas-snapshot/blob/master/plugin.yaml#L2 as well?
Considering a new release would be required for this plugin.

@theBeginner86 theBeginner86 added area/ci Continuous integration | Build and release kind/chore Necessary task labels Apr 13, 2025
@ritzorama
Copy link
Member

LGTM!

You might want to incorporate an update to https://github.com/meshery-extensions/helm-kanvas-snapshot/blob/master/plugin.yaml#L2 as well? Considering a new release would be required for this plugin.

Great suggestion!

@ritzorama
Copy link
Member

I opened a PR with a plugin version update (for this release) and an issue for future enhancement.

@leecalcote
Copy link
Member

Thank you, @ritzorama. This is precisely what we discussed. This is helpful.

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gooood! :smiling

@leecalcote leecalcote merged commit 2f6a3e9 into meshery-extensions:master Apr 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous integration | Build and release kind/chore Necessary task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants