fix the ODXLINK reference resolution fallback to ignore the DOCREF attributes #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tributes this is only relevant for invalid datasets which specify references with incorrect DOCREF and/or DOCTYPE attributes. This patch should make ODXLINK reference resolution work in non-strict mode for such datasets. Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Alexander Walz <[email protected]>
|
@nada-ben-ali: this hopefully fixes the root cause of #392. can you verify? |
|
cool, thanks. it is probably a good idea to prop up the reference resolution fallback code anyway, right? |
I never saw an OEM file where that would be needed, only exception was the ODX 2.0 files, and that's fixed already |
|
fair enough. let's close this... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only relevant for invalid datasets which specify references with incorrect DOCREF and/or DOCTYPE attributes. This patch should make ODXLINK reference resolution work in non-strict mode for such datasets.
Andreas Lauser <[email protected]>, on behalf of MBition GmbH.
Provider Information