-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add support for Bresser CO2 PN 7009977 and HCHO/VOC PN 7009978 sensors #2815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/devices/bresser_7in1.c
Outdated
|
||
/** | ||
Decoder for Bresser Weather Center 7-in-1 and Air Quality PM2.5 / PM10, outdoor sensors. | ||
Decoder for Bresser Weather Center 7-in-1 and Air quality sensors. | ||
Air Quality PM2.5/PM10 PN 7009970 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is markdown, for nice display the three device lines should start with a dash - Air…
src/devices/bresser_7in1.c
Outdated
Raw : | ||
SType Startup & Channel | ||
| | | ||
{207}dab6d782acd9 a 1 ad9aad9aad9aaaaaaaaaaaaaaaaae99aaaaa00 Type = 0xa = 10, Startup = 0, ch = 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code blocks need to be indented 4 spaces (preview in any markdown editor)
src/devices/bresser_7in1.c
Outdated
/* clang-format off */ | ||
data = data_make( | ||
"model", "", DATA_STRING, "Bresser-7in1", | ||
"model", "", DATA_STRING, "Bresser-AIR-PM", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add // should be "Bresser-Air"
but you can not change existing model names.
Thank you so much for working through analysis and implementation so quickly! |
Thanks, with pleasure. Most of the decode part was already in place, I "just" added 2 sensor types. 😉 |
Many thanks @ProfBoc75 for having handled this, really appreciated 👍 |
I confirm both devices are now properly supported, thank you very much again 👍 |
This pr is related to the 2 issues #2813 #2814 in order to add support for the 2 Air quality sensors
CO2 sensor PN 7009977
HCHO / VOC sensor PN 7009978
These sensors are based on the same protocol as current Bresser 7in1 weather station. This PR is updating this device.
Thx.