fix: some Cotech-367959 clones do not have the light sensor installed. #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this is a good sanity check. |
obones
force-pushed
the
device-nicetymeter0366
branch
from
e902f38 to
a2f4b79
Compare
|
I've done just that. My initial version was also changing the model field value, but I guess it's not desirable and I can live with it being static anyway. |
obones
force-pushed
the
device-nicetymeter0366
branch
from
a2f4b79 to
26b24ab
Compare
obones
added a commit
to obones/rtl_433
that referenced
this pull request
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a NicetyMeter 0366 weather station here that gets picked up as Cotech-367959 just fine.
The only thing is that Light intensity and UV index values are never changing and completely bogus which is quite expected as this model does not have a light sensor.
To avoid confusion, this PR removes the values from the output if it finds them to match what has been observed with my device.
If need be, I can create a PR on the tests projects with a sample signal final.