Skip to content

Change verbosity to match log level #2264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2022
Merged

Change verbosity to match log level #2264

merged 1 commit into from
Dec 4, 2022

Conversation

zuckschwerdt
Copy link
Collaborator

@zuckschwerdt zuckschwerdt commented Dec 4, 2022

Changes verbosity numbers (0-4) to match new log levels (1-8).
We default to a new level of 4 (WARNING) and each -v options increases the level by 1 unchanged.

The new level allow to distinguish between normal and abnormal state messages:

  • FATAL (1): A fatal error. Not actually used, fatal errors usually fprintf and terminate. This is the highest priority.
  • CRITICAL (2): A critical message. The user usually needs to see this.
  • ERROR (3): An error. An operation did not complete successfully, but the application as a whole is not affected.
  • WARNING (4): A warning. An operation completed with an unexpected result.
  • NOTICE (5): A notice, which is an information with just a higher priority.
  • INFO (6): An informational message, usually denoting the successful completion of an operation.
  • DEBUG (7): A debugging message.
  • TRACE (8): A tracing message. This is the lowest priority.

Note that we adopted the SoapySDR log levels but change CRITICAL to be a normal message.
We denote only FATAL, ERROR, and WARNING as abnormal. FATAL will terminate, ERROR indicates an important problem, and WARNING can likely be ignored.

This builds on #2263 and is preparation for #2254

@zuckschwerdt zuckschwerdt merged commit 5e6cec4 into master Dec 4, 2022
@zuckschwerdt zuckschwerdt deleted the feat-verblog branch December 4, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant