fineoffset: Add explanation of supposed PM10 value, and call it estimated #1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After discussion in merbanan#1640 this commit adjusts the comment about the WH0290 particulate sensor, mostly surrounding the nature of the field labeled PM10. The measurement of the sensor serial port was done by @peteakalad, and the determination of the pm2.5/pm10 conversion was done by @gdt with input from @peteakalad. (This commit does not change variable names or API-visible text.)
gdt
changed the title
| @@ -411,7 +443,7 @@ static int fineoffset_WH0290_callback(r_device *decoder, bitbuffer_t *bitbuffer) | |||
| "id", "ID", DATA_INT, id, | |||
| "battery_ok", "Battery Level", DATA_FORMAT, "%.1f", DATA_DOUBLE, battery_ok, | |||
| "pm2_5_ug_m3", "2.5um Fine Particulate Matter", DATA_FORMAT, "%i ug/m3", DATA_INT, pm25/10, | |||
| "pm10_0_ug_m3", "10um Coarse Particulate Matter", DATA_FORMAT, "%i ug/m3", DATA_INT, pm100/10, | |||
| "estimated_pm10_0_ug_m3", "Estimate of 10um Coarse Particulate Matter", DATA_FORMAT, "%i ug/m3", DATA_INT, pm100/10, | |||
There was a problem hiding this comment.
needs same change in output_fields_WH25
There was a problem hiding this comment.
Fixed, I think - but I didn't understand until just now.
As discussed at length in merbanan#1460, the value transmitted as PM10 is not actally PM10, but a value that is slightly more than PM2.5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussion in #1640
this commit adjusts the comment about the WH0290 particulate sensor,
mostly surrounding the nature of the field labeled PM10.
The measurement of the sensor serial port was done by @peteakalad, and
the determination of the pm2.5/pm10 conversion was done by @gdt.
Following consensus from #1640, change description to call it "estimated", as a compromise betwen calculated and alleged.