-
Notifications
You must be signed in to change notification settings - Fork 1.4k
add pressure and temperature value #1654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks! I'll test in the next few days. |
|
||
data = data_make( | ||
"model", "", DATA_STRING, "Ford", | ||
"type", "", DATA_STRING, "TPMS", | ||
"id", "", DATA_STRING, id_str, | ||
"code", "", DATA_STRING, code_str, | ||
"pressure", "", DATA_STRING, pressure_str, | ||
"temperature", "", DATA_STRING, temperature_str, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make this "temperature_C", "", DATA_INT, temperature,
please. remove "temperature_str"
|
||
data = data_make( | ||
"model", "", DATA_STRING, "Ford", | ||
"type", "", DATA_STRING, "TPMS", | ||
"id", "", DATA_STRING, id_str, | ||
"code", "", DATA_STRING, code_str, | ||
"pressure", "", DATA_STRING, pressure_str, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make this "pressure_psi",
... please. remove "pressure_str"
Manually merged. The output is very likely wrong. We really need a table of infaltion/deflation codes and a range of temperatures. |
Pressure value is correct: received on air packed and related with information which vehicle send over CAN. Temperature is not tested because module not send temperature information, but this formula look good: tested in house temp ~24C, outdoor ~0, and value from comment. Distance is related to temperature change in C, F is distance 1.8. |
#781