Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

fix: Add missing yaml header #2046

Merged
merged 2 commits into from
Feb 28, 2025
Merged

fix: Add missing yaml header #2046

merged 2 commits into from
Feb 28, 2025

Conversation

gau-nernst
Copy link
Contributor

Describe Your Changes

  • Add missing yaml-cpp/yaml.h header to get definition for YAML::Node::IsDefined()

On my Windows VM, it fails to build without that header

model_source_service.obj : error LNK2019: unresolved external symbol "public: bool __cdecl YA
ML::Node::IsDefined(void)const " (?IsDefined@Node@YAML@@QEBA_NXZ) referenced in function "cla
ss std::optional<class std::basic_string<char,struct std::char_traits<char>,class std::alloca
tor<char> > > __cdecl huggingface_utils::GetModelAuthorCortexsoHub(class std::basic_string<ch
ar,struct std::char_traits<char>,class std::allocator<char> > const &)" (?GetModelAuthorCorte
xsoHub@huggingface_utils@@YA?AV?$optional@V?$basic_string@DU?$char_traits@D@std@@V?$allocator
@D@2@@std@@@std@@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@3@@Z) [C:\Users\
menlo\cortex.cpp\engine\build\cortex-server.vcxproj]
C:\Users\menlo\cortex.cpp\engine\build\cortex-server.exe : fatal error LNK1120: 1 unresolved
externals [C:\Users\menlo\cortex.cpp\engine\build\cortex-server.vcxproj]

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@gau-nernst gau-nernst added this to Menlo Feb 28, 2025
@github-project-automation github-project-automation bot moved this to Investigating in Menlo Feb 28, 2025
@gau-nernst gau-nernst self-assigned this Feb 28, 2025
@gau-nernst gau-nernst merged commit fd4edc0 into dev Feb 28, 2025
8 checks passed
@gau-nernst gau-nernst deleted the fix/yaml_header branch February 28, 2025 07:16
@LeVinhGithub LeVinhGithub moved this from Investigating to Completed in Menlo Mar 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants