This repository was archived by the owner on Jul 4, 2025. It is now read-only.
fix: correct Linux cpu usage #2039
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request includes significant updates to the hardware service and CPU information handling. The main changes involve refactoring the CPU information retrieval, removing redundant code, and updating the hardware service to use the new CPU information structure.
Refactoring and Code Simplification:
engine/utils/hardware/cpu_info.h
: Refactored theGetCPUUsage
function to handle CPU usage calculation for different operating systems within theCpuInfo
struct. Added new methods and members to theCpuInfo
struct to support this functionality.engine/utils/hardware/cpu_usage.h
: Removed the entire file as its functionality has been integrated intocpu_info.h
.Hardware Service Updates:
engine/services/hardware_service.cc
: Updated theGetHardwareInfo
method to use the newcpu_info_
member for retrieving CPU information.engine/services/hardware_service.h
: Addedcortex::hw::CpuInfo cpu_info_
as a member of theHardwareService
class.Miscellaneous:
engine/services/hardware_service.h
: Moved the#include <mutex>
directive to fix include order.engine/services/hardware_service.cc
: Removed redundant logging statements in theRestart
method.Fixes Issues
Self Checklist