This repository was archived by the owner on Jul 4, 2025. It is now read-only.
fix: add metadata #1875
Merged
fix: add metadata #1875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vansangpfiev
force-pushed
the
fix/model-sources
branch
from
0f33259 to
74d8dea
Compare
vansangpfiev
force-pushed
the
fix/model-sources
branch
from
c7139cc to
a3e3eb7
Compare
* feat: add amd gpu windows * chore: remove unused code * feat: get amd gpus * fix: clean * chore: cleanup * fix: set activate * fix: build windows * feat: linux * fix: add patches * fix: map cuda gpus * fix: build * chore: docs * fix: build * chore: clean up * fix: build * fix: build * chore: pack vulkan windows * chore: vulkan linux --------- Co-authored-by: vansangpfiev <[email protected]>
Co-authored-by: vansangpfiev <[email protected]>
chore: cherry pick AMD hardware API support
nguyenhoangthuan99
approved these changes
Feb 3, 2025
Co-authored-by: vansangpfiev <[email protected]>
… into fix/model-sources
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request includes several changes to the model handling in the
enginedirectory, focusing on enhancing the model source management and improving the database interactions. The most important changes include adding new methods for handling model sources, updating the database schema, and improving the logging and error handling.Enhancements to model source management:
engine/controllers/models.cc: Added a new methodGetModelSourceto handle requests for a specific model source.engine/controllers/models.h: Updated theModelsclass to include the newGetModelSourcemethod. [1] [2]Database schema and interaction improvements:
engine/database/models.cc: Modified theGetModelSourcesandGetModelsmethods to return detailedModelEntryobjects instead of simple strings.engine/database/models.h: Updated theModelsclass to reflect the changes in the return types ofGetModelSourcesandGetModels.engine/services/database_service.cc: Adjusted theDatabaseServiceclass methods to align with the newModelEntryreturn types.Logging and error handling improvements:
engine/services/model_service.cc: Enhanced logging for model parsing and downloading processes, and improved error handling in theAddHfOrgandAddHfRepomethods. [1] [2] [3] [4] [5] [6]engine/services/model_source_service.cc: Added detailed logging and error handling for model source management methods, includingRemoveModelSource,GetModelSources, andAddRepoSiblings. [1] [2] [3] [4] [5]Fixes Issues
Self Checklist