Add forwards compatibility for Contao 5.5 #41
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need some more time to review this. I'm not entirely happy with the current code base from MCW and I'll see if we can optimize it. |
|
No worries |
stefanheimes
added a commit
that referenced
this pull request
Mar 29, 2025
This PR addresses the following three issues: - It disables turbo-prefetching for link operations - Since Contao switched to choices in Contao 5.5, the width: auto will completely shrink the select - The MooRainbow picker was replaced in version 5.5. This PR adds backward compatibility, allowing the use of the contao-component. Since it's a direct dependency, it must be required, and the assets need to be loaded within your bundle. This will happen automatically if Contao > 5.5 is detected
stefanheimes
added a commit
that referenced
this pull request
Mar 29, 2025
|
Thank you very much for the changes and suggestions @zoglo. I've created a new branch with my changes. I've moved the JS and CSS inclusion for the ColorPicker into the event, so they are only loaded when actually needed. Additionally, I've adjusted function calls that already exist accordingly. I will review the changes for Stimulus and see if I can integrate it. Most elements are provided with events to ensure compatibility with different Contao versions. |
|
Superseded by #42 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the following three issues:
It disables turbo-prefetching for link operations, same as this PR – aaaccf8.
Since we've switched to choices in Contao 5.5, the
width: autowill completely shrink the select - 07628d4.The MooRainbow picker was replaced in version 5.5. This PR adds backward compatibility, allowing the use of the contao-component. Since it's a direct dependency, it must be required, and the assets need to be loaded within your bundle.
This will happen automatically if Contao > 5.5 is detected – a8c70c2.
Additional Information about using the old color picker
Please note that the color picker will only work in dark mode due to the new icon set, which uses two icons.
This is a known bug in the MooRainbow color picker, which is no longer used in Contao – contao/contao#7548.
Once this bundle no longer supports Contao 4.13 and 5.3, the color picker should be switched to the Stimulus component – contao/contao#7792.