Skip to content

Add possibility to use public IP #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 1, 2020
Merged

Conversation

feraudet
Copy link
Contributor

@feraudet feraudet commented Jul 9, 2020

Hello,

This PR add possibility to use public IP instead private one

@mateuszkwiatkowski
Copy link

Hi, we're also interested in using this feature. What's preventing this PR from being merged?

@jimsheldon
Copy link
Contributor

@feraudet thanks for the contribution, sorry for the delay. We will review this in the next few days.

@jimsheldon jimsheldon merged commit 8ecb7f4 into meltwater:master Dec 1, 2020
@jimsheldon
Copy link
Contributor

Sorry this took so long! We made changes to our process around pull requests, hopefully we'll be faster in the future.

@jimsheldon
Copy link
Contributor

Published new release with this feature https://github.com/meltwater/terraform-aws-asg-dns-handler/releases/tag/v2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants