Skip to content

Add pyproject.toml for Custom Node Registry #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2024

Conversation

haohaocreates
Copy link
Contributor

@haohaocreates haohaocreates commented May 21, 2024

We are building a global registry for custom nodes (similar to PyPI). The registry makes using custom nodes more reliable by reserving globally unique names for each custom node, and supporting semantic versioning.

Here’s some more information on the registry.

Action Required:

  • Go to the registry. Login and create a publisher id. Comment it here and we will update the PR (or just merge it and change it yourself).
  • Merge the separate Github Actions PR and run the workflow.
    If you want to publish the node manually, install the cli and run comfy node publish

Please message me on Discord if you have any questions!

@haohaocreates haohaocreates requested a review from melMass as a code owner May 21, 2024 02:02
Copy link
Owner

@melMass melMass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I'll merge this one before the CI

@melMass melMass merged commit 5951c90 into melMass:main May 21, 2024
@haohaocreates
Copy link
Contributor Author

Hey @melMass, Saw that you merged the PR which is amazing!!!!! Just a few last steps to get you onboarded 🚀

Steps:

  1. Go to the registry. [https://www.comfyregistry.org/]
  2. Login and create a publisher id.
  3. Update the toml file with your publisher ID, and publish your node either through the CLI or with GH Actions!

There's also like a 1minute video we made too teehee - https://youtu.be/WhOZZOgBggU

Let me know if there is anything else I can help with!!"

@melMass
Copy link
Owner

melMass commented Jun 20, 2024

I will do it today!
I realized I need to version up each time I push to main for the registry right?
If so I will think of a way to automate it, and probably work more with PRs

@haohaocreates
Copy link
Contributor Author

haohaocreates commented Jun 20, 2024 via email

@melMass
Copy link
Owner

melMass commented Jun 21, 2024

@haohaocreates I realize I think did what you asked back when we merged this?

I already have a publisher id:

PublisherId = "mel"

https://registry.comfy.org/publishers/mel

I will fix auto version today

@haohaocreates
Copy link
Contributor Author

haohaocreates commented Jun 21, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants