Skip to content

Lighten futures dependency #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025

Conversation

paolobarbolini
Copy link
Contributor

@paolobarbolini paolobarbolini commented Jul 23, 2025

Pull Request

Related issue

None

What does this PR do?

  • This PR replaces futures with futures-core + futures-channel + futures-util with reduced features. This reduces the dependency tree making projects using meilisearch-sdk faster to compile.

PR checklist

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Summary by CodeRabbit

  • Chores
    • Updated dependency management for futures crates to use more granular components.
    • Adjusted internal import paths to reflect new dependency structure.
    • No changes to user-facing features or functionality.

Copy link
Contributor

coderabbitai bot commented Jul 23, 2025

Walkthrough

The changes refactor futures crate dependencies in Cargo.toml, splitting the monolithic futures dependency into futures-core, futures-channel, and futures-util with specific features. Corresponding import paths in Rust source files are updated to use these more granular crates. No logic or public API changes are introduced.

Changes

File(s) Change Summary
Cargo.toml Replaced futures dependency with futures-core, futures-channel, and futures-util (with features).
src/request.rs Updated import from futures::io::Cursor to futures_util::io::Cursor.
src/reqwest.rs Changed imports from futures to futures_core, futures_io, and updated pinning approach.
src/utils.rs Changed import from futures::channel::oneshot::channel to futures_channel::oneshot::channel.

Estimated code review effort

2 (~15 minutes)

Poem

In the garden of crates, dependencies grew,
The futures split up, as all bunnies knew.
Granular imports, so neat and precise,
Refactored with care—oh, isn't that nice?
With paws on the code, I hop and I cheer,
For tidier paths and a codebase more clear! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c349b35 and 7479405.

📒 Files selected for processing (4)
  • Cargo.toml (1 hunks)
  • src/request.rs (1 hunks)
  • src/reqwest.rs (2 hunks)
  • src/utils.rs (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • src/request.rs
🚧 Files skipped from review as they are similar to previous changes (3)
  • Cargo.toml
  • src/utils.rs
  • src/reqwest.rs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: integration-tests
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jul 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.76%. Comparing base (4218082) to head (7479405).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #688   +/-   ##
=======================================
  Coverage   85.76%   85.76%           
=======================================
  Files          19       19           
  Lines        5860     5860           
=======================================
  Hits         5026     5026           
  Misses        834      834           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Mubelotix Mubelotix added the skip-changelog The PR will not appear in the release changelogs label Jul 24, 2025
@Mubelotix Mubelotix merged commit 5dd4375 into meilisearch:main Jul 24, 2025
10 checks passed
@Mubelotix
Copy link
Collaborator

Thank you!

@curquiza curquiza added maintenance Anything related to maintenance (CI, tests, refactoring...) and removed skip-changelog The PR will not appear in the release changelogs labels Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants