-
Notifications
You must be signed in to change notification settings - Fork 100
Lighten futures
dependency
#688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lighten futures
dependency
#688
Conversation
WalkthroughThe changes refactor futures crate dependencies in Cargo.toml, splitting the monolithic futures dependency into futures-core, futures-channel, and futures-util with specific features. Corresponding import paths in Rust source files are updated to use these more granular crates. No logic or public API changes are introduced. Changes
Estimated code review effort2 (~15 minutes) Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
c349b35
to
7479405
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #688 +/- ##
=======================================
Coverage 85.76% 85.76%
=======================================
Files 19 19
Lines 5860 5860
=======================================
Hits 5026 5026
Misses 834 834 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thank you! |
Pull Request
Related issue
None
What does this PR do?
futures
withfutures-core
+futures-channel
+futures-util
with reduced features. This reduces the dependency tree making projects usingmeilisearch-sdk
faster to compile.PR checklist
Summary by CodeRabbit