[1.x] E2EE does not work with dummy publishers

[phwang4]

What version of Janus is this happening on?
Started to not work from Janus 1.2.2

Have you tested a more recent version of Janus too?
1.2.2, 1.2.4, and 1.3.1 all have the same issue.

Was this working before?
Commit d954e0f caused it to not work. Anytime before this it is fine.

Is there a gdb or libasan trace of the issue?
N/A

Additional context
The specific error message that I am getting is "Can't have end-to-end encrypted feed in this subscription" which comes from this block:

sub_e2ee = publisher->e2ee;
if(e2ee && !sub_e2ee) {
    JANUS_LOG(LOG_ERR, "Can't have not end-to-end encrypted feed in this subscription (%s)\n", feed_id_str);

There should probably be some check if the publisher is dummy or not to go down this error flow.

[lminiero]

I think the error is "normal", in the sense that the VideoRoom plugin allows, by default, publishers to either use or not use E2EE: of course, due to the way our negotiation works, you cannot subscribe to publishers that are not all of the same type, so they should either all be E2EE, or not at all. Dummy publishers are created as non-E2EE publishers, which is what causing the problem you're experiencing.

I think there are a couple of fixes that will be needed:

1. if a room is created with require_e2ee set to true, then the dummy publisher should be marked as E2EE automatically;
2. if a room is not created with require_e2ee set to true, then publishers can be of any kind; this means that we need a new property (dummy_e2ee?) to explicitly state if we want the dummy publisher to be marked as an E2EE publisher. The default would of course be false, to be backwards compatible.

[lminiero]

@phwang4 please see the PR above, which implements the changes I described in my previous comment.

[phwang4]

Thanks for the quick response. Everything looks good.

[lminiero]

Does this mean you tested and it works as expected for you now?

[phwang4]

Sorry for the confusion, I just looked at the changes which look like they work, but I haven't tested it.

I was going to test the changes once they get released on the next version.

[lminiero]

I'm not going to merge until I have feedback it works as expected, so please test and let us know.

[phwang4]

Just tested the dummy-e2ee branch and am able to get calls working again, with everything working as expected.