Add typing for all attributes and the main value #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulolaup
requested changes
Feb 18, 2025
- changing to unified datablass CQLTypeParameter - removing deprecated atributes fhirvaluepath, termcodefhirpath
paulolaup
requested changes
Feb 19, 2025
- Fix termCodeFhirPath still being added - Fix generation for Consent which is located in a different file combined-consent-generation.py
paulolaup
requested changes
Feb 19, 2025
There was a problem hiding this comment.
We also should think about remodeling the attributesFhirPaths entry and contained elements naming. Ideally they would be changed as follows:
attributeFhirPathstoattributes- any contained elements with names like
attribute<name>to just<name>
With this approach we would have a more consistent naming scheme that follows the principle of forming namespaces for subelements.
Since this change was not mentioned in the issue initially, I will amend it unless you have any objections.
attributeFhirPaths to attributes
any contained elements with names like attribute<name> to just <name>
removing termCodeFhirPath valueFhirPath from class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.