This repository was archived by the owner on Jan 28, 2019. It is now read-only.
fixed uniqueWithin validation bugs. #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 27, 2015 11:27
Issue: https://github.com/medic/medic-projects/issues/56 This validation was failing because the lucene query was incorrectly constructed. - To query on integer values we need to use the <int> prefix on the query otherwise the query doesn't match and always returns an empty array. - formatParam was failing on integer values with: lib/validation.js:36 value = value.replace(/"/g, '\\"'); ^ TypeError: Object 1 has no method 'replace' - It seems the ISO date standard (the one returned by .toISOString() with the trailing Z that designates Zulu/GMT time) fails on Lucene. I opened an upstream issue for this and left a comment in the code. Net change looks like this: // fails ``` patient_name:"irene" AND last_menstrual_period:"1" AND reported_date:[2015-07-27T13:14:40.564Z TO 3000-01-01T00:00:00] ``` // works ``` patient_name:"irene" AND last_menstrual_period<int>:1 AND reported_date:[2015-07-27T13:14:40.564 TO 3000-01-01T00:00:00] ```
|
Feel free to merge when it's ready browndav. |
|
browndav I was hoping to get this in RC today so let me know if there's anything I can do to help. |
|
Code review passed; merge away.
|
mandric
added a commit
that referenced
this pull request
Oct 27, 2015
fixed uniqueWithin validation bugs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://github.com/medic/medic-projects/issues/56
This validation was failing because the lucene query was incorrectly
constructed.
To query on integer values we need to use the prefix on the
query otherwise the query doesn't match and always returns an empty
array.
formatParam was failing on integer values with:
lib/validation.js:36
value = value.replace(/"/g, '"');
^
TypeError: Object 1 has no method 'replace'
It seems the ISO date standard (the one returned by .toISOString()
with the trailing Z that designates Zulu/GMT time) fails on Lucene. I
opened an upstream issue for this and left a comment in the code.
Net change looks like this:
// fails
// works