-
Notifications
You must be signed in to change notification settings - Fork 280
feat(#10036): add PersonQualifier
and related functions
#10043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sugat009
merged 12 commits into
medic:9835-add-cht-datasource-apis-for-creation-and-update-of-contacts-and-reports
from
apoorvapendse:create-person-local
Jun 13, 2025
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
215d1b2
feat(#10036): add `PersonQualifier` and related functions
apoorvapendse cbc4aaa
refactor `isContactQualifier` to use common checker
apoorvapendse 07a3e92
refactor to reuse `byContactQualifierNonAssertive`
apoorvapendse 8e37179
extract lineage bloat check in a function.
apoorvapendse 740295c
refactor contact type checker to use boolean pattern
apoorvapendse 9081f1f
fix logical error in `hasBloatedLineage`
apoorvapendse 577ed6e
add unit tests for `byPersonQualifier`
apoorvapendse 7958908
refactor boolean returns
apoorvapendse b5b3551
add tests for `isPersonQualifier`
apoorvapendse 3427c99
hydrate `reported_date` if absent in `by.*` functions
apoorvapendse 5fe209a
mutate `qualifier` instead of referenced obj.
apoorvapendse 566a085
add test containing `reported_date` in data
apoorvapendse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: if the
reported_date
does not exist, shouldn't it be added to it? Or are you planning on adding it elsewhere?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, added in the latest commit.