-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Edge 17 already supported [prefer_]related_applications
in PWA manifest
#27234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
@tomayac FYI, BCD says that |
@captainbrosset I thought it was now with https://issues.chromium.org/issues/40144143 fixed!? |
[prefer_]related_applications
in PWA manifest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If Chrome did not support this before 139 (chromium/chromium@d05d574), then didn't Edge 79-138 support these either?
@@ -13,7 +13,9 @@ | |||
"chrome_android": { | |||
"version_added": "44" | |||
}, | |||
"edge": "mirror", | |||
"edge": { | |||
"version_added": "17" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"version_added": "17" | |
"version_added": "17", | |
"version_removed": "79" |
@@ -12,7 +12,9 @@ | |||
"chrome_android": { | |||
"version_added": "44" | |||
}, | |||
"edge": "mirror", | |||
"edge": { | |||
"version_added": "17" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"version_added": "17" | |
"version_added": "17", | |
"version_removed": "79" |
This bug is for the
My understanding is that Chrome (and Edge) have had support for So I think this PR, as is, is correct. |
Else, @dmurph is another person who's closer to this. |
Summary
I'm changing the Edge compat data for the
related_applications
manifest member from false to 17 (and the relatedprefer_related_applications
member).The reason being that BCD says
getInstalledRelatedApps
is supported, butrelated_applications
isn't.This makes no sense since you can't really use the former without the latter. The
getInstalledRelatedApps
method returns the subset from the apps that are listed inrelated_applications
which are currently installed on the device where the code is running.So, the apps first need to be listed in the
related_applications
array, in the manifest, which means that the manifest member is supported.Test results and supporting details
Finding when this was added is a bit difficult.
The EdgeHTML 17's release notes say that support for PWAs were added to the browser in EdgeHTML 17.
This is confirmed by this Edge blog post from 2018.
The reason I think that support for PWA came with support for
related_applications
is that the Web App manifest section of the PWA docs from back then does mention therelated_applications
manifest member.Using the Wayback Machine, I was able to confirm that the PWA docs did not exist prior to EdgeHTML 17 being released.