Skip to content

Add WebDriver BiDi data for command/event parameters #26993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025
Merged

Conversation

mdn-bot
Copy link
Collaborator

@mdn-bot mdn-bot commented Jun 6, 2025

(This PR was generated by the update-webdriver-bidi-data workflow.)

@github-actions github-actions bot added data:webdriver Compat data for WebDriver features. https://developer.mozilla.org/docs/Web/WebDriver size:m [PR only] 25-100 LoC changed labels Jun 6, 2025
Copy link
Contributor

github-actions bot commented Jun 6, 2025

Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs).

@caugner caugner marked this pull request as draft June 6, 2025 13:17
@github-actions github-actions bot added the size:l [PR only] 101-1000 LoC changed label Jun 6, 2025
@mdn-bot mdn-bot force-pushed the webdriver-bidi branch 6 times, most recently from 0374a19 to 28b2fd3 Compare June 13, 2025 04:40
@github-actions github-actions bot added the size:xl [PR only] >1000 LoC changed label Jun 16, 2025
@mdn-bot mdn-bot force-pushed the webdriver-bidi branch 8 times, most recently from e5400cf to a75400a Compare June 23, 2025 04:43
@mdn-bot mdn-bot force-pushed the webdriver-bidi branch 6 times, most recently from 071aab0 to ea6f748 Compare June 30, 2025 04:42
@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Jun 30, 2025
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Jul 1, 2025
@mdn-bot mdn-bot force-pushed the webdriver-bidi branch 2 times, most recently from 5b46134 to e749028 Compare July 2, 2025 14:18
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the changes, and noted especially the following cases:

  • (More important) Noticable version changes or status changes.
  • (Less urgent) In some cases, parameters are partially supported, but there is no note explaining the limitation (should answer: what works, what doesn't work). (This can be recorded in the spreadsheet using a "Note" in the version cell.)

@whimboo @sadym-chromium Let me know if you have any questions. 🙏

"version_added": "101",
"partial_implementation": true,
"notes": "Basic support (see [bug 1730641](https://bugzil.la/1730641))"
"version_added": "101"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whimboo Before, Firefox data for browsingContext.navigate() indicated partial support from 101, now it states full support (including all parameters) in that version. Correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the meta bug shows we have had a lot of follow-up fixes for this command and we are not done yet with all of them. I don't think that we should list each and every improvement in the note to this command. The initial landing contained support for all the parameters. Do you think otherwise?

Copy link
Contributor

@caugner caugner Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be helpful for developers to mention the most relevant limitations (which doesn't imply marking the feature as partial).

For example:

Does not handle navigations that start a download (bug 1763126), navigations to javascript URLs (bug 1763131), or navigations where the initial request never comes back or times out (bug 1763135).

"version_added": false
"version_added": "135",
"partial_implementation": true,
"notes": "Basic support"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sadym-chromium Would be good to add details about Chrome's partial implementation of the webExtension.install() command, ideally linking to a bug.

"chrome": {
"version_added": "135",
"partial_implementation": true,
"notes": "Basic support"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sadym-chromium Would be good to add details about Chrome's partial implementation of the extensionData parameter of the webExtension.install command, ideally linking to a bug.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't plan to implement other types of extensionData, so no tracking bug there.

"chrome": {
"version_added": "135",
"partial_implementation": true,
"notes": "Basic support"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sadym-chromium Would be good to add details about Chrome's partial implementation of the extension parameter of the webExtension.uninstall command, ideally linking to a bug.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I marked it as partial, as unlike our e2e tests, the WPT tests are not passing. It needs som investigation for extended status.

"firefox": {
"version_added": "122",
"partial_implementation": true,
"notes": "Basic support"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whimboo Would be good to add details about Firefox's partial implementation of the response parameter of the network.authRequired event, ideally linking to a bug.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juliandescottes could you please have a look?

@mdn-bot mdn-bot force-pushed the webdriver-bidi branch 2 times, most recently from 67f4e65 to fd0ca91 Compare July 3, 2025 15:46
@mdn-bot mdn-bot force-pushed the webdriver-bidi branch 2 times, most recently from 1cb0e38 to b6d2489 Compare July 4, 2025 09:11
@whimboo
Copy link
Contributor

whimboo commented Jul 4, 2025

@caugner I assume this PR still needs another update to fetch the latest changes from the spreadsheet.

@mdn-bot mdn-bot force-pushed the webdriver-bidi branch 2 times, most recently from d29c8b9 to dd0bb70 Compare July 4, 2025 16:13
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @whimboo @sadym-chromium @juliandescottes for your swift input! 🙌

The new parameter support data is looking good now, so let's land this as is, and follow up on the remaining open review threads later. 🎉

@caugner caugner marked this pull request as ready for review July 4, 2025 16:51
@caugner caugner changed the title Update WebDriver BiDi data Add WebDriver BiDi data for command/event parameters Jul 4, 2025
@caugner caugner merged commit 5248fd4 into main Jul 4, 2025
11 checks passed
@caugner caugner deleted the webdriver-bidi branch July 4, 2025 16:56
@mdn-bot mdn-bot mentioned this pull request Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webdriver Compat data for WebDriver features. https://developer.mozilla.org/docs/Web/WebDriver size:l [PR only] 101-1000 LoC changed size:m [PR only] 25-100 LoC changed size:xl [PR only] >1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants