Skip to content

Add Bun to BCD #23440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add Bun to BCD #23440

wants to merge 10 commits into from

Conversation

queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Jun 19, 2024 •
edited
Loading

This PR is a draft of what it would look like to add Bun and its data to BCD, if we desired to do so. Note: this draft is meant to be a proof of concept for #18484.

Releases are obtained from Bun's GitHub repository. Compatibility data is obtained from unjs/runtime-compat.

@github-actions github-actions bot added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. data:wasm Compat data for Web Assembly features. https://developer.mozilla.org/en-US/docs/WebAssembly labels Jun 19, 2024
@github-actions github-actions bot added the schema Isses or pull requests regarding the JSON schema files used in this project. label Jul 8, 2024
@nektro
Copy link

nektro commented Sep 27, 2024

is there anything needed to push this along/fill out more data? happy to pitch in if it'd help

@queengooborg
Copy link
Contributor Author

This is just a proof of concept right now, and is awaiting owner consensus to add!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Oct 8, 2024
@github-actions github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Nov 18, 2024
@caugner
Copy link
Contributor

caugner commented Dec 10, 2024

Since Bun is currently covered by runtime-compat, I would suggest closing this PR for now.

@queengooborg
Copy link
Contributor Author

NodeJS and Deno are also covered by runtime-compat, but we include data for both of them in BCD. I think that it's helpful to include Bun's data in BCD especially as there's been lots of consumer interest, and runtime-compat only obtains the data for the latest versions of each runtime.

I would like to keep this PR open as a draft as a reminder to come to a decision.

@queengooborg queengooborg added the semver-minor-bump A change that adds a new, non-potentially-breaking feature for consumers label Jan 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Jan 16, 2025
@github-actions github-actions bot added size:xl [PR only] >1000 LoC changed and removed merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. labels Feb 17, 2025
@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Apr 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@connerlphillippi
Copy link

@caugner bumping this, we would really love it if your team added support!

@ddbeck ddbeck mentioned this pull request Jul 1, 2025
Open
@github-actions github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Jul 2, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs).

@queengooborg queengooborg marked this pull request as ready for review July 2, 2025 23:52
alii
alii reviewed Jul 2, 2025
View reviewed changes
api/Response.json
@@ -335,7 +335,7 @@
],
"support": {
"bun": {
"version_added": "1.0"
"version_added": false
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does false mean here? Only commenting as curious/didn't see it in other cases..

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(bun does support the Fetch API! 😄)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

false means that the feature is unsupported -- in this case, this particular feature is whether the body property is a readable byte stream. This is the test that's being run. The error message is "ReadableStreamBYOBReader needs a ReadableByteStreamController", which seems to indicate that it's not a byte stream.).

Safari also reports false for this.

(Don't worry, it's not saying that the entire Response / Fetch API is unsupported!)

Copy link

@alii alii Jul 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks for the helpful explanation! (My mistake - I didn't see in the GitHub diff viewer that it was the specific "readable_byte_stream" check 😆)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alii alii alii left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript data:wasm Compat data for Web Assembly features. https://developer.mozilla.org/en-US/docs/WebAssembly schema Isses or pull requests regarding the JSON schema files used in this project. semver-minor-bump A change that adds a new, non-potentially-breaking feature for consumers size:xl [PR only] >1000 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@queengooborg @nektro @caugner @connerlphillippi @alii