From js any

[OlivierBlanvillain]

This PR adds a def fromJsAny(json: js.Any): JValue method for both safe and unsafe ATDs.

As illustrated in the tests, the intent is to have the following law:

forAll { j: JValue => fromJsAny(j.toJsAny) == j }

I could not make this pass (I think) due to rounding errors on JNumber, depending on your feedback I could rework this with either static test cases or a solution to the rounding stuff.

[mdedetrich]

Can you say Scala.js Javascript object/value rather than just Javascript object/value. This is to clear confusion from Scala.js Javascript versus Javascript alone (which the AST also supports).

Also applies to anywhere else where it happens to be mentioned

[OlivierBlanvillain]

I revered the doc for toJsAny, but I'm not sure I understand the nuance here, isn't it the case that js.Any correspond to both Javascript values and Scala.js Javascript values?

[mdedetrich]

Thanks for the pull request.

I am not sure that it makes sense that any possible Scala.js javascript value can be converted to a JSON value. Doesn't js.Any also encapsulate types such as Javascript function and whatnot (which makes no sense in JSON whatsoever)? Sounds to me that it makes more sense for fromJsAny to be return an Option[JValue] rather than just a JValue.

I will look at the rounding error later today, definitely don't want an implementation that is needlessly losing numeric data but I have to see how Scala.js handles numbers in more detail (as to why this happening).

[OlivierBlanvillain]

Sorry for taking so long (and for such little rework). BTW the problem on number rounding still remains; I did not investigated it at all...

[mdedetrich]

Thanks, I will have a look into the rounding error

[mdedetrich]

I am going to close this. @OlivierBlanvillain I will reopen it when I you update your PR after #30 is done since a lot of changes have happened since then.