You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently jNumberRegex is a simple String, which means that for every application of the regex, i.e. every creation of a JNumber instance from a String the regex has to be compiled before it is run.
IMHO the regex should be precompiled or, even better, turned into a manual check.
Of course one could also debate whether the check is really necessary at all, since JNumber instances will typically be created either by a parser or by one of the non-string JNumber.apply overloads, which will never created illegal number strings anyway.
The text was updated successfully, but these errors were encountered:
Currently
jNumberRegex
is a simpleString
, which means that for every application of the regex, i.e. every creation of aJNumber
instance from aString
the regex has to be compiled before it is run.IMHO the regex should be precompiled or, even better, turned into a manual check.
Of course one could also debate whether the check is really necessary at all, since
JNumber
instances will typically be created either by a parser or by one of the non-stringJNumber.apply
overloads, which will never created illegal number strings anyway.The text was updated successfully, but these errors were encountered: