Skip to content

Fix glob patterns (* and **) on Windows #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Marcus10110
Copy link

Fixes #15

Also enables the tests on Windows, by bypassing this bug. That fix should probably stay in here, since Jake depends on this module, so the behavior of this.testFiles.include won't include our fix until this PR is first merged into filelist, then jake is updated.

The pattern is normalized right before being passed to minimatch, which uses glob to check for directory matches.
This converts Unix path separators back to Windows separators, so the regex replace is needed to convert them back to unix separators, as required by minimatch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

glob based matching broken on Windows
1 participant