Skip to content

Utilize uv for dependencies, and re-use containers where possible #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

M1kep
Copy link
Contributor

@M1kep M1kep commented Mar 17, 2025

No description provided.

Comment on lines -34 to +30
celery[redis]==5.4.0
celery==5.4.0
Copy link
Contributor Author

@M1kep M1kep Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See astral-sh/uv#1595 for rational and some background. TLDR: It shouldn't make a difference.

There's some more chatter here too(Is also linked in the uv issue above) - jazzband/pip-tools#1613

@huntcsg
Copy link
Contributor

huntcsg commented Mar 17, 2025

Is this just a performance improvement? UV has better dependency resolution?
This change seems fine. I just want to understand the benefit better.

@M1kep
Copy link
Contributor Author

M1kep commented Mar 17, 2025

Yeah, mostly performance. I think their dependency resolution has some more features, but I don't think they'll be of use in this project.
10x-100x according to the uv team - https://github.com/astral-sh/uv/blob/main/BENCHMARKS.md

uv performance improvements are more obvious in installation flows I believe, so would be curious to see the image build speedup by switching as well, but will keep that for later

@IsaacGemal
Copy link
Contributor

I like UV a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants