Hide preview box of unloaded tabs #2081
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mbnuqw semi-related question: are there any benefits of the popup preview over the in-page preview? In-page seems cleaner with no downside or difference in functionality that I've noticed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2079 (I can split if needed, just can't build without it)
Closes #2080
When hovering over an unloaded tab with tab preview turned on (either in-page and popup):
Before: preview box is large blank area
After: preview box not shown
Note: removed the bottom border radii to make it look more consistent when moving mouse over unloaded and loaded tabs. Let me know if you think it looks better without this.
Note: I think there might be a minimum window height, I couldn't figure out how to make the popup smaller if it's possible.