Add options for middle click on pinned tab #1911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, sounds reasonable. Will merge it despite Firefox's default behavior (closing pinned tab on middle click), since Sidebery has distinguishable "unloaded" state of a tab. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a separate configurable action for middle click on pinned tab.
Related issues:
#1304
#1320
Considering it doesn't make much sense to close pinned tabs with middle click (as one of the reasons of the "pinned" state is to make tab not so easily closeable), this pull request makes "discard" a default action for the middle click on pinned tab.
Available set of actions includes new option "unpin", which makes sense for the pinned tab, and excludes the option "duplicate as a child" (compared to the regular middle click configuration).