Skip to content

FEATURE REQUEST: Custom icon: local file selection instead of base64 #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
boldcompany opened this issue Oct 4, 2022 · 3 comments
Closed

Comments

@boldcompany
Copy link

Description

Currently, sidebery supports automatic loading of remote icons of a variety of formats. The user does not have to do anything special other than set appropriate add-on permissions and then include the URL string, such as...
ex: https://news.ycombinator.com/y18.gif

However, local icons do not work the same way. The user must manually enter a prefix...
ex: data:image/png;base64,
and then provide a base64-encoded icon...
ex: R0lGODlhEgASAKIAAP/jyvihV/aKLfmxc/////9mAAAAAAAAACH5BAAAAAAALAAAAAASABIAAAMpWLrc/jDKOQkRy8pBhuKeRAAKQFBBxwVUYY5twXVxodV3nLd77f9ASQIAOw==
which is probably counterintuitive to most users.

It would be very convenient if the user could simply enter, for example:
C:\Users\User1\Desktop\icon.png
...and sidebery would process and load the png automatically, as it does with the remote file.

@danielnichols
Copy link

I agree that adding base64 icons is not intuitive, although I feel like accessing file paths as described may run into some permission issues... Perhaps a better way to go about it would be to use an upload file dialog?

mbnuqw added a commit that referenced this issue Dec 10, 2022
Updated UI
Added: Local files support (#785)
Added: Option to fill custom icon with selected color
Removed: Base64 support
@quazar-omega
Copy link

Looks to be solved in stable too, thank you @mbnuqw!

@mbnuqw
Copy link
Owner

mbnuqw commented Mar 8, 2024

Available from v5.0.0

@mbnuqw mbnuqw closed this as completed Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants