breaking: panel/tabs are not being correctly restored

[br4nnigan]

Steps to reproduce

I can reproduce it by closing and reopening my browser

Expected behavior

panels with tabs are being restored

Actual behavior

all tabs from the default panel are being pushed into the adjecent panel. Also groups are being messed up in the process (basically group is flattened, one other tab of the group has a group with its name as parent, maybe this is due to the groups being managed by tab indexes, and since tabs from another panel are now in the panel the indexes get messed up).

As you can imagine this is really bad.

Debug info

Addon data

{ "settings": { "version": "4.10.1", "nativeScrollbars": true, "selWinScreenshots": true, "tabsCheck": true, "tabsFix": "notify", "markWindow": false, "markWindowPreface": "[Sidebery] ", "ctxMenuNative": true, "autoHideCtxMenu": "none", "ctxMenuRenderInact": true, "ctxMenuIgnoreContainers": "", "navBarLayout": "horizontal", "navBarInline": false, "hideAddBtn": false, "hideSettingsBtn": false, "navBtnCount": true, "hideEmptyPanels": false, "navActTabsPanelLeftClickAction": "none", "navActBookmarksPanelLeftClickAction": "none", "navMidClickAction": "none", "navSwitchPanelsWheel": true, "groupLayout": "grid", "skipEmptyPanels": false, "dndTabAct": true, "dndTabActDelay": 750, "dndTabActMod": "none", "dndExp": "pointer", "dndExpDelay": 0, "dndExpMod": "none", "stateStorage": "global", "warnOnMultiTabClose": "collapsed", "activateOnMouseUp": true, "activateLastTabOnPanelSwitching": true, "showTabRmBtn": true, "showTabCtx": true, "hideInact": false, "activateAfterClosing": "next", "activateAfterClosingPrevRule": "visible", "activateAfterClosingNextRule": "tree", "activateAfterClosingGlobal": false, "activateAfterClosingNoFolded": true, "activateAfterClosingNoDiscarded": true, "shiftSelAct": true, "askNewBookmarkPlace": true, "tabsRmUndoNote": true, "nativeHighlight": false, "tabsUnreadMark": false, "tabsReloadLimit": 5, "tabsReloadLimitNotif": true, "tabsPanelSwitchActMove": true, "moveNewTabPin": "start", "moveNewTabParent": "last_child", "moveNewTabParentActPanel": false, "moveNewTab": "end", "pinnedTabsPosition": "panel", "pinnedTabsList": false, "pinnedAutoGroup": false, "tabsTree": true, "groupOnOpen": true, "tabsTreeLimit": "none", "hideFoldedTabs": false, "autoFoldTabs": false, "autoFoldTabsExcept": "none", "autoExpandTabs": true, "rmChildTabs": "folded", "tabsChildCount": true, "tabsLvlDots": false, "discardFolded": false, "discardFoldedDelay": 0, "discardFoldedDelayUnit": "sec", "tabsTreeBookmarks": true, "treeRmOutdent": "branch", "bookmarksPanel": true, "warnOnMultiBookmarkDelete": "collapsed", "openBookmarkNewTab": false, "midClickBookmark": "open_new_tab", "actMidClickTab": true, "autoCloseBookmarks": false, "autoRemoveOther": false, "highlightOpenBookmarks": false, "activateOpenBookmarkTab": false, "showBookmarkLen": false, "bookmarksRmUndoNote": true, "fontSize": "xs", "bgNoise": false, "animations": true, "animationSpeed": "fast", "theme": "default", "style": "light", "sidebarCSS": true, "groupCSS": false, "snapNotify": true, "snapExcludePrivate": true, "snapInterval": 1, "snapIntervalUnit": "hr", "snapLimit": 7, "snapLimitUnit": "day", "hScrollThroughPanels": false, "scrollThroughTabs": "none", "scrollThroughVisibleTabs": false, "scrollThroughTabsSkipDiscarded": false, "scrollThroughTabsExceptOverflow": true, "scrollThroughTabsCyclic": false, "tabDoubleClick": "none", "tabLongLeftClick": "none", "tabLongRightClick": "none", "tabsPanelLeftClickAction": "none", "tabsPanelDoubleClickAction": "tab", "tabsPanelRightClickAction": "menu", "tabsPanelMiddleClickAction": "tab", "syncName": "firefox.home", "syncSaveSettings": true, "syncSaveCtxMenu": true, "syncSaveStyles": true, "syncAutoApply": false }, "permissions": { "allUrls": true, "tabHide": true, "actualAllUrls": true, "actualTabHide": true }, "storage": { "size": "3.7 mb", "props": { "bookmarksMenu": "226 b", "bookmarksPanelMenu": "54 b", "cssVars": "1.6 kb", "disabledKeybindings": "937 b", "expandedBookmarks": "2 b", "favAutoCleanTime": "10 b", "favUrls": "40 kb", "favicons": "902.7 kb", "lastSnapTime": "13 b", "panelIndex": "1 b", "panels_v4": "1.3 kb", "prevTabsData_v4": "51.2 kb", "profileID": "14 b", "settings": "2.8 kb", "sidebarCSS": "567 b", "snapshots_v4": "2.7 mb", "tabsData_v4": "53.9 kb", "tabsMenu": "293 b", "tabsPanelMenu": "184 b" } }, "panels": [ { "type": "bookmarks", "id": "bookmarks", "cookieStoreId": "bookmarks", "name": 9, "icon": "...", "bookmarks": true, "lockedPanel": false, "skipOnSwitching": false }, { "type": "tabs", "id": "niPkN6hQ0vm6", "name": 5, "icon": "...", "color": "...", "customIconSrc": "", "customIcon": "", "lockedTabs": false, "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "firefox-default", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "" }, { "type": "tabs", "id": "qFigcMm79DS5", "name": 4, "icon": "...", "color": "...", "customIconSrc": "", "customIcon": "", "lockedTabs": false, "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "" }, { "type": "tabs", "id": "smXN3XH7Nje6", "name": 4, "icon": "...", "color": "...", "customIconSrc": "", "customIcon": "", "lockedTabs": false, "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "" }, { "type": "default", "id": "firefox-default", "name": 7, "icon": "...", "cookieStoreId": "firefox-default", "lockedTabs": false, "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true } ], "containers": [], "cssVars": { "tabs_height": "28px" }, "sidebarCSSLen": 543, "windows": [ { "state": "maximized", "incognito": false, "tabsCount": 153 } ], "tabsMenu": [ [ "undoRmTab", "mute", "reload", "bookmark" ], "separator-1", [ { "name": "Move to" }, "moveToNewWin", "moveToWin", "moveToPanel" ], [ { "name": "Reopen in" }, "reopenInNewWin", "reopenInWin", "reopenInCtr" ], "separator-2", "pin", "duplicate", "discard", "copyUrls", "separator-3", "group", "flatten", "separator-4", "close" ], "bookmarksMenu": [ [ { "name": "Open in" }, "openInNewWin", "openInNewPrivWin", "openInCtr" ], "separator-5", "createBookmark", "createFolder", "createSeparator", "separator-6", "sortByName", "sortByLink", "sortByTime", "separator-7", "copyUrls", "edit", "delete" ], "bookmarks": { "bookmarksCount": 1160, "foldersCount": 59, "separatorsCount": 6, "maxDepth": 4 } }

Logs

[albino1]

An attempt to fix this was just committed last week:

afecf35
720ff2f

It should be in 4.10.2, however I don't know when that version will get released.

[br4nnigan]

also panels are seemingly randomly created as hidden, and worst of all bugs, "configure panel" shows a list where panels are missing. Or dont I understand how to use this? I love this addon so far but there's these breaking bugs

[megamorphg]

Sadly this still occurs in v5 too. I don't remember if it was worse in v4 but in v5 it only happens to a few tabs at a time on a specific window.
v5 issue just for the tabs flattened issue: #711

[zhufeng]

5.0.0rc4 still has this bug, I created 3 panels and each with about 10-20 tabs, sometimes after reopen firefox, all tabs are added to default panel and no tabs in other 2 panels, the other 2 panels are still visible in Setting menu.

[mbnuqw]

Should be fixed in v5.0.0. Feel free to reopen if not.