Skip to content

Tabs get flattened after 10'th nesting. #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
denikryt opened this issue May 4, 2022 · 8 comments
Closed

Tabs get flattened after 10'th nesting. #627

denikryt opened this issue May 4, 2022 · 8 comments

Comments

@denikryt
Copy link

denikryt commented May 4, 2022

Steps to reproduce

Just open a new child tab in the next child ten times and more.

Expected behavior

Tabs saves reliationships no matter how deep they are nesting.
In settings the maximum nesting is set to off, it means unlimited amount of childs.

Actual behavior

Tabs get flattened after 10'th nesting.

Debug info

Addon data

Logs

@dexeonify
Copy link

dexeonify commented May 7, 2022

Fixed in v5 beta
image

On further testing it seems the limit was pushed up to 12. If you collapse the parent tab, all of the children tabs are collapsed correctly as well.

The question is, when do you need such a deep nesting?

@denikryt
Copy link
Author

denikryt commented May 8, 2022

@dexeonify It happens while I'm surfing wikipedia and other further articles from it, for example. For navigation experience such bug a bit confusing and counterproductive.

@denikryt
Copy link
Author

denikryt commented May 8, 2022

Also I'm keeping tabs in tree structure and in some cases hierarchy exceed the limit of nesting.

mbnuqw added a commit that referenced this issue May 9, 2022
@mbnuqw
Copy link
Owner

mbnuqw commented May 9, 2022

I've increased the max level (to 16) and changed styles for overflowed tabs to stay at the max level.

@denikryt
Copy link
Author

denikryt commented May 9, 2022

🙏🏻

@kakhulu31
Copy link

kakhulu31 commented Aug 12, 2022

I've increased the max level (to 16) and changed styles for overflowed tabs to stay at the max level.

Thanks for bringing your attention to this issue, however I dont think that increasing the max level to 16 will solve the problem for those who go so deep.
Tst has a better approach to solve this problem, it simply reduces the horizontal gap between descendants the deeper you go without forcing any limit. This option would actually help.
And the ultimate solution would be adding a horizontal scroll bar as well as removing the limit.

@mbnuqw
Copy link
Owner

mbnuqw commented Aug 19, 2022

Dynamic indent values is a nice idea, definitely will try to add it. Horizontal scroll is not possible b/c:

  • It will prevent horizontal scroll wheel to switch between panels (if configured)
  • It's only possible with native scrollbars
  • It will not work with drag and drop pointer positioning (or require its complete reworking)

@mbnuqw
Copy link
Owner

mbnuqw commented Sep 1, 2022

Fixed in v4.10.2

@mbnuqw mbnuqw closed this as completed Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants