Skip to content

Don't switch panel if background tab is auto moved #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pintassilgo opened this issue Sep 26, 2021 · 1 comment
Closed

Don't switch panel if background tab is auto moved #478

pintassilgo opened this issue Sep 26, 2021 · 1 comment

Comments

@pintassilgo
Copy link

When a tab is auto moved by matching URL rules, the destination panel is always activated. This shouldn't happen if the moved tab is not the active tab.

Additionally, it would be great, in such case, to provide some highlighting to emphasize that one background tab was auto moved, because this can go unnoticed, especially when you middleclick a bunch of links to open in new tabs and one of them gets auto moved. My suggestion is to blink twice over the icon of the destination panel.
pintassilgo added a commit to pintassilgo/sidebery that referenced this issue Sep 26, 2021
@pintassilgo
don't switch panel if moved tab is not active
7d996fd 
mbnuqw#478
pintassilgo added a commit to pintassilgo/sidebery that referenced this issue Oct 3, 2021
@pintassilgo
don't activate background tab that was automoved to panel with newTab…
3772eba 
…Ctx != none

mbnuqw#478
@pintassilgo
Copy link
Author

Fixed in #266, except by the suggestion of providing some highlight to notify that a tab was auto moved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pintassilgo