Skip to content

changing discard title for misunderstanding? #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
denemier opened this issue May 7, 2020 · 5 comments
Closed

changing discard title for misunderstanding? #222

denemier opened this issue May 7, 2020 · 5 comments

Comments

@denemier
Copy link

denemier commented May 7, 2020

Discard Tabs label feels like deleting tab, maybe change it to sleep/freeze tabs

@MartinGraive
Copy link

@mbnuqw
Copy link
Owner

mbnuqw commented May 10, 2020

I used title from the API docs (as @MartinGraive pointed). If it sounds wrong (I'm not a native speaker), how about "Unload tab"? - at least, it more accurate describes the target action. Oh, and I'll need (maybe) change the icon.
screenshot-2020-05-10 23:11:48

@denemier
Copy link
Author

unload tabs sounds good, by the way i liked the icon for unloading looks good to me it's classical.

But you can maybe change the mute sound icon into something like youtube players sound level icon in the future.
By the way where are you from? Greetings from turkey

@mlissner
Copy link

FWIW, I came here to file a similar bug, but I was convinced that "Discard" meant "Close" since there's no option in the menu to do that. I would have never clicked on discard had I not come to this bug and learned otherwise.

I agree that changing it to "Unload" would be better. Neat feature!

@mbnuqw
Copy link
Owner

mbnuqw commented Jun 3, 2020

Fixed in v4.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants