Skip to content

Ignore DownThemAll addon's Manager Window for "Move to another window" #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jathek opened this issue Apr 19, 2020 · 1 comment
Closed

Comments

@jathek
Copy link

jathek commented Apr 19, 2020

Steps to reproduce

  1. Install DownThemAll
  2. Open DownThemAll manager
  3. Right click on a tab in the original window

Expected behavior

  1. The DownThemAll manager is a special window and should not be a target for new tabs, so Sidebery should behave as if no other windows exist.

Actual behavior

  1. Sidebery allows the DownThemAll manager window to be a target for moving tabs.

Environment info

OS: win
Firefox: 76.0
Addon: 4.8.0

{ "settings": { "version": "4.8.0", "nativeScrollbars": true, "selWinScreenshots": true, "tabsCheck": true, "tabsFix": "notify", "ctxMenuNative": false, "autoHideCtxMenu": "none", "ctxMenuRenderInact": true, "navBarLayout": "horizontal", "navBarInline": false, "hideAddBtn": true, "hideSettingsBtn": false, "navBtnCount": true, "hideEmptyPanels": false, "navMidClickAction": "none", "navSwitchPanelsWheel": false, "groupLayout": "list", "dndTabAct": false, "dndTabActDelay": 750, "dndTabActMod": "none", "dndExp": "pointer", "dndExpDelay": 0, "dndExpMod": "none", "stateStorage": "global", "warnOnMultiTabClose": "any", "activateOnMouseUp": true, "activateLastTabOnPanelSwitching": false, "skipEmptyPanels": false, "showTabRmBtn": false, "showTabCtx": true, "hideInact": true, "activateAfterClosing": "next", "activateAfterClosingPrevRule": "tree", "activateAfterClosingNextRule": "tree", "activateAfterClosingGlobal": false, "activateAfterClosingNoFolded": true, "activateAfterClosingNoDiscarded": true, "shiftSelAct": true, "askNewBookmarkPlace": true, "tabsRmUndoNote": true, "nativeHighlight": true, "tabsUnreadMark": true, "tabsReloadLimit": 5, "moveNewTabPin": "end", "moveNewTabParent": "last_child", "moveNewTabParentActPanel": false, "moveNewTab": "end", "pinnedTabsPosition": "panel", "pinnedTabsList": false, "pinnedAutoGroup": true, "tabsTree": true, "groupOnOpen": true, "tabsTreeLimit": "none", "hideFoldedTabs": true, "autoFoldTabs": true, "autoFoldTabsExcept": 2, "autoExpandTabs": true, "rmChildTabs": "folded", "tabsChildCount": true, "tabsLvlDots": true, "discardFolded": false, "discardFoldedDelay": 0, "discardFoldedDelayUnit": "sec", "tabsTreeBookmarks": true, "bookmarksPanel": true, "warnOnMultiBookmarkDelete": "collapsed", "openBookmarkNewTab": false, "midClickBookmark": "open_new_tab", "actMidClickTab": false, "autoCloseBookmarks": false, "autoRemoveOther": false, "highlightOpenBookmarks": true, "activateOpenBookmarkTab": false, "showBookmarkLen": true, "bookmarksRmUndoNote": true, "fontSize": "m", "bgNoise": true, "animations": true, "animationSpeed": "fast", "theme": "default", "style": "auto", "sidebarCSS": true, "groupCSS": false, "snapNotify": true, "snapExcludePrivate": false, "snapInterval": 180, "snapIntervalUnit": "min", "snapLimit": 14, "snapLimitUnit": "day", "hScrollThroughPanels": false, "scrollThroughTabs": "none", "scrollThroughVisibleTabs": false, "scrollThroughTabsSkipDiscarded": false, "scrollThroughTabsExceptOverflow": true, "scrollThroughTabsCyclic": false, "tabDoubleClick": "reload", "tabLongLeftClick": "none", "tabLongRightClick": "none", "tabsPanelLeftClickAction": "none", "tabsPanelDoubleClickAction": "tab", "tabsPanelRightClickAction": "menu", "tabsPanelMiddleClickAction": "undo", "syncName": "DeeperThought", "syncSaveSettings": true, "syncSaveCtxMenu": true, "syncSaveStyles": true, "syncAutoApply": false }, "permissions": { "allUrls": true, "tabHide": true, "actualAllUrls": true, "actualTabHide": true }, "storage": { "size": "8.8 mb", "props": { "bookmarksMenu": "226 b", "bookmarksPanelMenu": "54 b", "containers_v4": "524 b", "disabledKeybindings": "24 b", "expandedBookmarks": "2 b", "favAutoCleanTime": "10 b", "favUrls": "26.2 kb", "favicons": "553.4 kb", "lastSnapTime": "13 b", "panelIndex": "1 b", "panels_v4": "1.2 kb", "prevTabsData_v4": "78.6 kb", "profileID": "14 b", "settings": "2.5 kb", "sidebarCSS": "7.4 kb", "snapshots_v4": "8.1 mb", "tabsData_v4": "79.4 kb", "tabsMenu": "369 b", "tabsPanelMenu": "97 b" } }, "panels": [ { "type": "bookmarks", "id": "bookmarks", "cookieStoreId": "bookmarks", "name": 9, "icon": "...", "bookmarks": true, "lockedPanel": false }, { "type": "default", "id": "firefox-default", "name": 7, "icon": "...", "cookieStoreId": "firefox-default", "lockedTabs": false, "lockedPanel": false, "noEmpty": false, "newTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true }, { "type": "tabs", "id": "Qf9vV8t_uFI9", "name": 7, "icon": "...", "color": "...", "customIconSrc": "", "customIcon": "", "lockedTabs": false, "lockedPanel": false, "noEmpty": false, "newTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "" }, { "type": "tabs", "id": "fiTbDpS9AQyX", "name": 9, "icon": "...", "color": "...", "customIconSrc": "", "customIcon": "", "lockedTabs": false, "lockedPanel": false, "noEmpty": false, "newTabCtx": "firefox-container-4", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "" }, { "type": "tabs", "id": "vrjq0zPV5Rdv", "name": 6, "icon": "...", "color": "...", "customIconSrc": "", "customIcon": "", "lockedTabs": false, "lockedPanel": false, "noEmpty": false, "newTabCtx": "firefox-container-8", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "" } ], "cssVars": "TypeError: can't convert undefined to object", "sidebarCSSLen": 7332, "windows": [ { "state": "maximized", "incognito": false, "tabsCount": 708 }, { "state": "normal", "incognito": false, "tabsCount": 1 }, { "state": "maximized", "incognito": true, "tabsCount": 1 } ], "tabsMenu": [ [ "reload", "discard", "mute" ], "separator-1", [ { "name": "" }, "moveToWin", "moveToNewWin", "moveToPanel" ], "separator-3795259787627495", [ { "name": "" }, "pin", "group", "flatten" ], "separator-23946656137316935", [ { "name": "" }, "duplicate", "reopenInWin", "reopenInNewWin", "separator-36995635286684236", "reopenInCtr" ], "separator-2391613243580316", [ { "name": "" }, "bookmark", "copyUrls", "close" ] ], "bookmarksMenu": [ [ { "name": "Open in" }, "openInNewWin", "openInNewPrivWin", "openInCtr" ], "separator-5", "createBookmark", "createFolder", "createSeparator", "separator-6", "sortByName", "sortByLink", "sortByTime", "separator-7", "copyUrls", "edit", "delete" ], "bookmarks": { "bookmarksCount": 4526, "foldersCount": 326, "separatorsCount": 0, "maxDepth": 8 } }
@mbnuqw
Copy link
Owner

mbnuqw commented Jun 3, 2020

Fixed in v4.9.0

@mbnuqw mbnuqw closed this as completed Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants