Skip to content

Tab grouping and panels lost. #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jak2k opened this issue Dec 9, 2024 · 13 comments
Open

Tab grouping and panels lost. #1910

Jak2k opened this issue Dec 9, 2024 · 13 comments

Comments

@Jak2k
Copy link

Jak2k commented Dec 9, 2024

Steps to reproduce

  • Open Firefox

Actual behavior

All tabs are ungrouped and moved to the main panel. Pinned tabs are not affected.

Expected behavior

My groups and panels should be like they were before.

System

Fedora 41

Firefox version

133.0

Sidebery version

5.2.0

Logs

No response

@BeeMargarida
Copy link

BeeMargarida commented Dec 11, 2024

This happened to me twice today. For some context, it happened after I booted up my computer and firefox restored the previous session.

These are my logs, if it helps

16:42:49.585 [sidebar] Init start [chunk-4KZVVU6Z.js:2:7890](moz-extension://a3a01501-f5cd-4853-be93-9f17b0fdaab5/chunk-4KZVVU6Z.js)
16:42:49.918 [sidebar:1] Sidebar.loadPanels [chunk-4KZVVU6Z.js:2:7890](moz-extension://a3a01501-f5cd-4853-be93-9f17b0fdaab5/chunk-4KZVVU6Z.js)
16:42:49.920 [sidebar:1] Sidebar.loadPanels: Done: 4ms [chunk-4KZVVU6Z.js:2:7890](moz-extension://a3a01501-f5cd-4853-be93-9f17b0fdaab5/chunk-4KZVVU6Z.js)
16:42:49.931 [sidebar:1] Tabs.load [chunk-4KZVVU6Z.js:2:7890](moz-extension://a3a01501-f5cd-4853-be93-9f17b0fdaab5/chunk-4KZVVU6Z.js)
16:42:49.935 [sidebar:1] Tabs.restoreTabsState [chunk-4KZVVU6Z.js:2:7890](moz-extension://a3a01501-f5cd-4853-be93-9f17b0fdaab5/chunk-4KZVVU6Z.js)
16:42:54.932 [sidebar:1] IPC.connectTo: No confirmation: bg [chunk-4KZVVU6Z.js:2:7976](moz-extension://a3a01501-f5cd-4853-be93-9f17b0fdaab5/chunk-4KZVVU6Z.js)
16:42:55.932 [sidebar:1] IPC.request: No confirmation: bg isWindowTabsLocked [chunk-4KZVVU6Z.js:2:7976](moz-extension://a3a01501-f5cd-4853-be93-9f17b0fdaab5/chunk-4KZVVU6Z.js)
16:42:55.932 [sidebar:1] Tabs.findCachedData: mismatched: 1 1 66 [chunk-4KZVVU6Z.js:2:7976](moz-extension://a3a01501-f5cd-4853-be93-9f17b0fdaab5/chunk-4KZVVU6Z.js)
16:42:55.933 [sidebar:1] Tabs.restoreTabsFromSessionData [chunk-4KZVVU6Z.js:2:7890](moz-extension://a3a01501-f5cd-4853-be93-9f17b0fdaab5/chunk-4KZVVU6Z.js)
16:42:55.934 [sidebar:1] Tabs loading: Cannot find panels: -1 [chunk-4KZVVU6Z.js:2:7976](moz-extension://a3a01501-f5cd-4853-be93-9f17b0fdaab5/chunk-4KZVVU6Z.js)
16:42:55.934 [sidebar:1] Tabs.restoreTabsState: Done: 5999ms [chunk-4KZVVU6Z.js:2:7890](moz-extension://a3a01501-f5cd-4853-be93-9f17b0fdaab5/chunk-4KZVVU6Z.js)
16:42:55.949 [sidebar:1] Tabs.load: Done: 6017ms [chunk-4KZVVU6Z.js:2:7890](moz-extension://a3a01501-f5cd-4853-be93-9f17b0fdaab5/chunk-4KZVVU6Z.js)
16:42:55.952 [sidebar:1] Init end: 6367ms [chunk-4KZVVU6Z.js:2:7890](moz-extension://a3a01501-f5cd-4853-be93-9f17b0fdaab5/chunk-4KZVVU6Z.js)
16:42:56.954
[sidebar:1] IPC.request: Target port has an error:
 
Object { message: "No confirmation" }
[chunk-4KZVVU6Z.js:3:25](moz-extension://a3a01501-f5cd-4853-be93-9f17b0fdaab5/chunk-4KZVVU6Z.js)
16:42:56.954 [sidebar:1] IPC.request: Cannot find appropriate port, trying to reconnect... [chunk-4KZVVU6Z.js:2:7976](moz-extension://a3a01501-f5cd-4853-be93-9f17b0fdaab5/chunk-4KZVVU6Z.js)
16:43:01.954 [sidebar:1] IPC.connectTo: No confirmation: bg [chunk-4KZVVU6Z.js:2:7976](moz-extension://a3a01501-f5cd-4853-be93-9f17b0fdaab5/chunk-4KZVVU6Z.js)
16:43:01.955 [sidebar:1] IPC.request: No confirmation: bg cacheTabsData [chunk-4KZVVU6Z.js:2:7976](moz-extension://a3a01501-f5cd-4853-be93-9f17b0fdaab5/chunk-4KZVVU6Z.js)
16:43:53.730 [bg] Init start [chunk-4KZVVU6Z.js:2:7890](moz-extension://a3a01501-f5cd-4853-be93-9f17b0fdaab5/chunk-4KZVVU6Z.js)
16:43:53.737
[sidebar:1] IPC.request: Target port has an error:
 
Object { message: "No confirmation" }
[chunk-4KZVVU6Z.js:3:25](moz-extension://a3a01501-f5cd-4853-be93-9f17b0fdaab5/chunk-4KZVVU6Z.js)
16:43:53.737 [sidebar:1] IPC.request: Cannot find appropriate port, trying to reconnect... [chunk-4KZVVU6Z.js:2:7976](moz-extension://a3a01501-f5cd-4853-be93-9f17b0fdaab5/chunk-4KZVVU6Z.js)
16:43:53.980 [bg] Windows.isWindowTabsLocked 1 [chunk-4KZVVU6Z.js:2:7890](moz-extension://a3a01501-f5cd-4853-be93-9f17b0fdaab5/chunk-4KZVVU6Z.js)
16:43:54.149 [bg] IPC.onConnected sidebar 1 [chunk-4KZVVU6Z.js:2:7890](moz-extension://a3a01501-f5cd-4853-be93-9f17b0fdaab5/chunk-4KZVVU6Z.js)
16:43:54.150 [bg] Init end: 419ms

@gomaproi
Copy link

Can confirm that the same behavior happens to me too. (Sidebery 5.2.0, Firefox 133.0.3)

@cdavie-artium
Copy link

I just lost all my group nestings and came to Github to report this issue. (Sidebery 5.2.0, Firefox 134.0b9)

@fb913bf0de288ba84fe98f7a23d35edfdb22381

Happens to me almost every start, on multiple devices.

@mbnuqw
Copy link
Owner

mbnuqw commented Dec 29, 2024

Could you check if this issue still exists in version 5.2.0.10 (sidebery nightly release: https://github.com/mbnuqw/sidebery?tab=readme-ov-file#install)?

@Jak2k
Copy link
Author

Jak2k commented Dec 30, 2024

Could you check if this issue still exists in version 5.2.0.10 (sidebery nightly release: https://github.com/mbnuqw/sidebery?tab=readme-ov-file#install)?

Probably not. I couldn't reproduce it.

@Kaldo
Copy link

Kaldo commented Jan 15, 2025

This has happened multiple times in recent months and it just happened again when I turned on my PC today, all the tabs have moved to the first group and the other groups are empty. I'm on windows 10 / firefox 135.0b4

@elena-ferra
Copy link

This has been happening to me frequently now too, every couple of hours the groups will lose all their tabs.

@mbnuqw
Copy link
Owner

mbnuqw commented Jan 21, 2025

@elena-ferra, could you please provide logs (right after groups losing their tabs)?

How to get logs
  • Open DevTools (open this url in new tab: about:devtools-toolbox?id=%7B3c078156-979c-498b-8990-85f7987dd929%7D&type=extension).

  • Navigate to console tab.

  • Click on the trash bin icon (at the top-left) to clear console.

  • Then try to reproduce the issue.

  • If messages appear, copy and paste them here inside this codeblock, replacing this text.

@ElectricAlgorhythm
Copy link

ElectricAlgorhythm commented Jan 26, 2025

I recently changed OS and was having this issue, so I updated to nightly (5.3.1.2) and tried to restore from snapshot. Initially I thought updating to nightly resolved the tab flattening, but it looks like it's still happening sometimes, including when I captured the logs below.
Here's my logs:

[bg] Snapshots.openWindows [chunk-LRG32NMS.js:2:11221](moz-extension://fbed5051-fc1b-4544-bd5f-65c35da8593e/chunk-LRG32NMS.js)
[bg] Snapshots.openWindow [chunk-LRG32NMS.js:2:11221](moz-extension://fbed5051-fc1b-4544-bd5f-65c35da8593e/chunk-LRG32NMS.js)
[bg] Windows.createWithTabs 106 [chunk-LRG32NMS.js:2:11221](moz-extension://fbed5051-fc1b-4544-bd5f-65c35da8593e/chunk-LRG32NMS.js)
[sidebar] Init start [chunk-LRG32NMS.js:2:11221](moz-extension://fbed5051-fc1b-4544-bd5f-65c35da8593e/chunk-LRG32NMS.js)
[sidebar] Settings.loadSettings() [chunk-LRG32NMS.js:2:11221](moz-extension://fbed5051-fc1b-4544-bd5f-65c35da8593e/chunk-LRG32NMS.js)
[sidebar:430] IPC.setupConnectionListener() [chunk-LRG32NMS.js:2:11221](moz-extension://fbed5051-fc1b-4544-bd5f-65c35da8593e/chunk-LRG32NMS.js)
[sidebar:430] Sidebar.loadPanels [chunk-LRG32NMS.js:2:11221](moz-extension://fbed5051-fc1b-4544-bd5f-65c35da8593e/chunk-LRG32NMS.js)
[sidebar:430] Sidebar.loadPanels: Done: 12ms [chunk-LRG32NMS.js:2:11221](moz-extension://fbed5051-fc1b-4544-bd5f-65c35da8593e/chunk-LRG32NMS.js)
[sidebar:430] Tabs.load [chunk-LRG32NMS.js:2:11221](moz-extension://fbed5051-fc1b-4544-bd5f-65c35da8593e/chunk-LRG32NMS.js)
[sidebar:430] Tabs.restoreTabsState [chunk-LRG32NMS.js:2:11221](moz-extension://fbed5051-fc1b-4544-bd5f-65c35da8593e/chunk-LRG32NMS.js)
[sidebar:430] IPC.request bg: isWindowTabsLocked: Connection is not ready: Pending request [chunk-LRG32NMS.js:2:11221](moz-extension://fbed5051-fc1b-4544-bd5f-65c35da8593e/chunk-LRG32NMS.js)
[bg] IPC.onConnect(sidebar, 430): [chunk-LRG32NMS.js:2:11221](moz-extension://fbed5051-fc1b-4544-bd5f-65c35da8593e/chunk-LRG32NMS.js)
[bg] IPC.onConnect(sidebar, 430): New connection [chunk-LRG32NMS.js:2:11221](moz-extension://fbed5051-fc1b-4544-bd5f-65c35da8593e/chunk-LRG32NMS.js)
[bg] IPC.onConnected sidebar 430 [chunk-LRG32NMS.js:2:11221](moz-extension://fbed5051-fc1b-4544-bd5f-65c35da8593e/chunk-LRG32NMS.js)
[bg] Windows.isWindowTabsLocked 430 undefined [chunk-LRG32NMS.js:2:11221](moz-extension://fbed5051-fc1b-4544-bd5f-65c35da8593e/chunk-LRG32NMS.js)
[sidebar:430] Tabs.findCachedData: mismatched: 1 1 113 [chunk-LRG32NMS.js:2:11307](moz-extension://fbed5051-fc1b-4544-bd5f-65c35da8593e/chunk-LRG32NMS.js)
[sidebar:430] Tabs.findCachedData: mismatched: 1 1 106 [chunk-LRG32NMS.js:2:11307](moz-extension://fbed5051-fc1b-4544-bd5f-65c35da8593e/chunk-LRG32NMS.js)
[sidebar:430] Tabs.restoreTabsFromSessionData [chunk-LRG32NMS.js:2:11221](moz-extension://fbed5051-fc1b-4544-bd5f-65c35da8593e/chunk-LRG32NMS.js)
[sidebar:430] Tabs.restoreTabsState: Done: 8ms [chunk-LRG32NMS.js:2:11221](moz-extension://fbed5051-fc1b-4544-bd5f-65c35da8593e/chunk-LRG32NMS.js)
[sidebar:430] Tabs.load: Done: 14ms [chunk-LRG32NMS.js:2:11221](moz-extension://fbed5051-fc1b-4544-bd5f-65c35da8593e/chunk-LRG32NMS.js)
[sidebar:430] Init end: 57ms [chunk-LRG32NMS.js:2:11221](moz-extension://fbed5051-fc1b-4544-bd5f-65c35da8593e/chunk-LRG32NMS.js)
[bg] Windows.createWithTabs: Done [chunk-LRG32NMS.js:2:11221](moz-extension://fbed5051-fc1b-4544-bd5f-65c35da8593e/chunk-LRG32NMS.js)
[sidebar:430] Tabs.tryToRestoreTabsStateFromSessionData 99 [chunk-LRG32NMS.js:2:11221](moz-extension://fbed5051-fc1b-4544-bd5f-65c35da8593e/chunk-LRG32NMS.js)
[setup] Settings.loadSettings() [chunk-LRG32NMS.js:2:11221](moz-extension://fbed5051-fc1b-4544-bd5f-65c35da8593e/chunk-LRG32NMS.js)
[bg] IPC.onConnect(setup, 430): [chunk-LRG32NMS.js:2:11221](moz-extension://fbed5051-fc1b-4544-bd5f-65c35da8593e/chunk-LRG32NMS.js)
[bg] IPC.onConnect(setup, 430): New connection [chunk-LRG32NMS.js:2:11221](moz-extension://fbed5051-fc1b-4544-bd5f-65c35da8593e/chunk-LRG32NMS.js)

(Running LibreWolf 134.0)

Edit: It looks like exporting and importing a json snapshot restores properly

@mbnuqw
Copy link
Owner

mbnuqw commented Jan 27, 2025

@ElectricAlgorhythm, thanks for logs, they pointed out the reason (at least one of them) of losing tabs structure on opening window by Sidebery (e.g. opening snapshot window)

mbnuqw added a commit that referenced this issue Jan 27, 2025
This should prevent some cases of losing tabs structure on opening
window by sidebery e.g. opening snapshot window or moving tabs to new
window. (#1910)
@maanemann
Copy link

maanemann commented Feb 16, 2025

I have a similar issue, likely related. In my main window I have 4 panels used for categorizing (besides other temporary windows), and firefox is set to restore on startup. Yesterday I found one of the main window panels had been flattened and rearranged (I think it was after Windows bootup). The folders were preserved, but all folders and tabs are now in reverse order, the tabs are placed above the folders they used to be inside (as older siblings), and tabs that used to be childen of other tabs are equally placed above what used to be their parent tabs. All flattened, one level.

Another panel, probably the one that was active from last session, was mostle okay, except for one folder whoose content, I think, had been treated as described above. And today I found that a third panel had been completely flattened and rearranged, same way as described above. It may have happened simultanously, as I don't think I activated this third panel after the incident, until now.

The fourth and final panel was empty, maybe with a single tab, so not affected. And other open window(s?) weren't affected either.

I could try to reproduce, but honestly I don't have the nerves, or the time right now. I hope this was helpful anyway.

Let me know if (some of) the debug info from Sidebery would be useful (settings > help > show debug info). I guess at least this first part is: "addonVersion": "5.3.2", "firefoxVersion": "135.0"

@kmate95
Copy link

kmate95 commented Apr 8, 2025

Had similar experiences throughout the last months on Linux with always upto-date Firefox and Sidebery.

On startup I always restore the same session with four windows with 300 < tabs < 1000. If that provides any clue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests