Skip to content

fix: Implicit template type according to 2.6.0 zip library requirements #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

andriipopazov
Copy link

@andriipopazov andriipopazov commented Apr 4, 2025

This will fix compatiblity with https://crates.io/crates/xcframework as well as will support latest 2.6.0 zip

Error:

error[E0107]: missing generics for struct ZipFile``

@matzefriedrich could you accept this PR so it unblocks us?
thanks

@joshua-holmes
Copy link

Small suggestion to add to this PR:
Upgrade the zip version number from 2.1 to somewhere >=2.3.0 because everything below 2.3.0 has been yanked from crates.io.

@Paul-16098
Copy link

zip-extensions = { git = "https://github.com/andriipopazov/zip-extensions-rs", branch = "fix/2.6.0-zip-template" }

@matzefriedrich
Copy link
Owner

Hey guys, sorry for being late.. let me check what you did here. Could you provide some more details about the problems you´re facing, and how this PR addresses them; it seems to be more than one, correct?

@matzefriedrich
Copy link
Owner

Quick follow-up: I dug into the changes and was able to replicate the issue. The root cause is the need to bump the zip dependency to at least version 2.6. However, with that change, the zip/rand feature is no longer supported and needs to be removed from Cargo.toml; this was not included in the PR.

The current PR only patches the compiler errors that show up after the update, but doesn’t address the full migration. Since this needs cleanup, I’ll push a complete fix shortly. Thanks for kicking this off. Feel free to review once the new changes are live.

@matzefriedrich matzefriedrich self-assigned this Apr 21, 2025
@matzefriedrich
Copy link
Owner

Fixed by #20

@matzefriedrich matzefriedrich added the question Further information is requested label Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants