Skip to content

Xcode 10 and Swift 4.2 #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 27, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .swift-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
4.0
4.2
42 changes: 9 additions & 33 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,59 +5,35 @@ language: objective-c
xcode_workspace: OneTimePassword.xcworkspace
xcode_scheme: OneTimePassword (iOS)

osx_image: xcode10
osx_image: xcode10.1

env:
- RUNTIME="iOS 8.4" DEVICE="iPhone 4s"
- RUNTIME="iOS 9.3" DEVICE="iPhone 6s"
- RUNTIME="iOS 10.3" DEVICE="iPhone 7 Plus"
- RUNTIME="iOS 11.3" DEVICE="iPhone X"
- RUNTIME="iOS 12.0" DEVICE="iPhone XS Max"
- RUNTIME="iOS 11.4" DEVICE="iPhone X"
- RUNTIME="iOS 12.1" DEVICE="iPhone XS Max"

# Include builds for watchOS
matrix:
include:
# Include an Xcode 9.0 build to test Swift 4.0 support
- osx_image: xcode9
env: RUNTIME="iOS 11.0" DEVICE="iPhone 8"
# Include an Xcode 9.2 build to test on iOS 8.x, because Xcode 9.3's iOS 8 simulator fails to launch
- osx_image: xcode9.2
env: RUNTIME="iOS 8.4" DEVICE="iPhone 4s"
# Include an Xcode 9.4 build to ensure compatibility until Xcode 10 is in widespread use
- osx_image: xcode9.4
env: RUNTIME="iOS 9.3" DEVICE="iPhone 6s"
# Include several build-only jobs for watchOS
- xcode_scheme: OneTimePassword (watchOS)
env: BUILD_ONLY="YES" RUNTIME="watchOS 5.0" DEVICE="Apple Watch Series 4 - 44mm"
env: BUILD_ONLY="YES" RUNTIME="watchOS 5.1" DEVICE="Apple Watch Series 4 - 44mm"
- xcode_scheme: OneTimePassword (watchOS)
osx_image: xcode9.4
env: BUILD_ONLY="YES" RUNTIME="watchOS 4.3" DEVICE="Apple Watch Series 3 - 38mm"
env: BUILD_ONLY="YES" RUNTIME="watchOS 4.2" DEVICE="Apple Watch Series 3 - 38mm"
- xcode_scheme: OneTimePassword (watchOS)
env: BUILD_ONLY="YES" RUNTIME="watchOS 3.2" DEVICE="Apple Watch Series 2 - 42mm"
- xcode_scheme: OneTimePassword (watchOS)
env: BUILD_ONLY="YES" RUNTIME="watchOS 2.0" DEVICE="Apple Watch - 38mm"
# Include Carthage builds
# Build with Carthage
- env:
before_script:
script: carthage build --no-skip-current
- osx_image: xcode9
env:
before_script:
script: carthage build --no-skip-current
# Include CocoaPods builds
# Build with CocoaPods
- env:
before_script:
script: pod lib lint --allow-warnings
- osx_image: xcode9
env:
before_install: gem update cocoapods
before_script:
script: pod lib lint --allow-warnings --verbose
allow_failures:
# Allow the Xcode 9 `pod lib lint` to fail, as this test method currently has an issue using the custom CommonCrypto module maps.
- osx_image: xcode9
env:
before_install: gem update cocoapods
before_script:
script: pod lib lint --allow-warnings --verbose

before_script:
- DEVICE_ID=com.apple.CoreSimulator.SimDeviceType.$(echo $DEVICE | sed -E -e "s/[ \-]+/ /g" -e "s/[^[:alnum:]]/-/g")
Expand Down
5 changes: 0 additions & 5 deletions CommonCrypto/README.md

This file was deleted.

4 changes: 0 additions & 4 deletions CommonCrypto/appletvos/module.modulemap

This file was deleted.

4 changes: 0 additions & 4 deletions CommonCrypto/appletvsimulator/module.modulemap

This file was deleted.

62 changes: 0 additions & 62 deletions CommonCrypto/injectXcodePath.sh

This file was deleted.

4 changes: 0 additions & 4 deletions CommonCrypto/iphoneos/module.modulemap

This file was deleted.

4 changes: 0 additions & 4 deletions CommonCrypto/iphonesimulator/module.modulemap

This file was deleted.

4 changes: 0 additions & 4 deletions CommonCrypto/macosx/module.modulemap

This file was deleted.

4 changes: 0 additions & 4 deletions CommonCrypto/watchos/module.modulemap

This file was deleted.

4 changes: 0 additions & 4 deletions CommonCrypto/watchsimulator/module.modulemap

This file was deleted.

8 changes: 0 additions & 8 deletions Configuration/OneTimePassword.xcconfig
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,3 @@ PRODUCT_BUNDLE_IDENTIFIER = me.mattrubin.onetimepassword;
INFOPLIST_FILE = Sources/Info.plist;

SWIFT_INSTALL_OBJC_HEADER = NO;

SWIFT_INCLUDE_PATHS[sdk=appletvos*] = $(SRCROOT)/CommonCrypto/appletvos;
SWIFT_INCLUDE_PATHS[sdk=appletvsimulator*] = $(SRCROOT)/CommonCrypto/appletvsimulator;
SWIFT_INCLUDE_PATHS[sdk=iphoneos*] = $(SRCROOT)/CommonCrypto/iphoneos;
SWIFT_INCLUDE_PATHS[sdk=iphonesimulator*] = $(SRCROOT)/CommonCrypto/iphonesimulator;
SWIFT_INCLUDE_PATHS[sdk=macosx*] = $(SRCROOT)/CommonCrypto/macosx;
SWIFT_INCLUDE_PATHS[sdk=watchos*] = $(SRCROOT)/CommonCrypto/watchos;
SWIFT_INCLUDE_PATHS[sdk=watchsimulator*] = $(SRCROOT)/CommonCrypto/watchsimulator;
18 changes: 1 addition & 17 deletions OneTimePassword.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -5,27 +5,11 @@ Pod::Spec.new do |s|
s.homepage = "https://github.com/mattrubin/OneTimePassword"
s.license = "MIT"
s.author = "Matt Rubin"
s.swift_version = "4.0"
s.swift_version = "4.2"
s.ios.deployment_target = "8.0"
s.watchos.deployment_target = "2.0"
s.source = { :git => "https://github.com/mattrubin/OneTimePassword.git", :tag => s.version }
s.source_files = "Sources/*.{swift}"
s.requires_arc = true
s.dependency "Base32", "~> 1.1.2"
s.pod_target_xcconfig = {
"SWIFT_INCLUDE_PATHS[sdk=appletvos*]" => "$(SRCROOT)/OneTimePassword/CommonCrypto/appletvos",
"SWIFT_INCLUDE_PATHS[sdk=appletvsimulator*]" => "$(SRCROOT)/OneTimePassword/CommonCrypto/appletvsimulator",
"SWIFT_INCLUDE_PATHS[sdk=iphoneos*]" => "$(SRCROOT)/OneTimePassword/CommonCrypto/iphoneos",
"SWIFT_INCLUDE_PATHS[sdk=iphonesimulator*]" => "$(SRCROOT)/OneTimePassword/CommonCrypto/iphonesimulator",
"SWIFT_INCLUDE_PATHS[sdk=macosx*]" => "$(SRCROOT)/OneTimePassword/CommonCrypto/macosx",
"SWIFT_INCLUDE_PATHS[sdk=watchos*]" => "$(SRCROOT)/OneTimePassword/CommonCrypto/watchos",
"SWIFT_INCLUDE_PATHS[sdk=watchsimulator*]" => "$(SRCROOT)/OneTimePassword/CommonCrypto/watchsimulator",
}
s.preserve_paths = "CommonCrypto/*"
# The prepare_command "will be executed after the Pod is downloaded."
# The script is *not* run on every build, or even on every `pod install`, so if the selected
# Xcode path changes after the pod is downloaded, you may need to clear the pod from the cache at
# ~/Library/Caches/CocoaPods so the script can update the modulemaps with the new path.
# https://guides.cocoapods.org/syntax/podspec.html#prepare_command
s.prepare_command = "CommonCrypto/injectXcodePath.sh"
end
Loading