Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Week view with times #653

Merged
merged 54 commits into from
Jul 31, 2018
Merged

WIP: Week view with times #653

merged 54 commits into from
Jul 31, 2018

Conversation

mattlewis92
Copy link
Owner

@mattlewis92 mattlewis92 commented Jul 20, 2018

This has to be one of the most requested features of all time and is now going to become part of the official api 🎉 The new UX is that all events appear in the bottom grid, and anything marked as allDay appears at the top (preserving the old behaviour)

Still to do:

  • drag and drop of hourly week view events
  • resizing of hourly week view events
  • allow dragging non snapped events onto the all day events block and vice versa
  • add an option to insert a template into the left hand column for the all day events label

Tests to write:

  • resizing an event from the end to another day on the right (and check ghost resizes)
  • resizing an event from the end to another day on the left (and check ghost resizes)
  • resizing an event from the start to another day on the left (and check ghost resizes)
  • resizing an event from the start to another day on the right (and check ghost resizes)
  • snapDraggedEvents = false: drag and drop of a multi day spanning event to another column and hour (where the original event didn't exist)
  • snapDraggedEvents = true: drag and drop of a multi day spanning event to another column and hour. Test temp events are created while dragging
  • test dragging an event from time to all day
  • test dragging an event from all day to time

Preview:
screen shot 2018-07-19 at 17 05 37

Closes #593

@codecov-io
Copy link

codecov-io commented Jul 20, 2018

Codecov Report

Merging #653 into 0.26 will increase coverage by 0.18%.
The diff coverage is 97.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##             0.26     #653      +/-   ##
==========================================
+ Coverage   97.53%   97.71%   +0.18%     
==========================================
  Files          37       38       +1     
  Lines         650      789     +139     
  Branches       72       97      +25     
==========================================
+ Hits          634      771     +137     
- Partials       16       18       +2
Impacted Files Coverage Δ
src/date-adapters/date-adapter.ts 100% <ø> (ø) ⬆️
...odules/week/calendar-week-view-header.component.ts 100% <ø> (ø) ⬆️
src/modules/week/calendar-week.module.ts 100% <ø> (ø) ⬆️
.../modules/common/calendar-resize-helper.provider.ts 100% <100%> (ø) ⬆️
.../common/calendar-native-date-formatter.provider.ts 100% <100%> (ø) ⬆️
...modules/week/calendar-week-view-event.component.ts 100% <100%> (ø) ⬆️
.../week/calendar-week-view-hour-segment.component.ts 100% <100%> (ø)
.../common/calendar-moment-date-formatter.provider.ts 100% <100%> (ø) ⬆️
...common/calendar-angular-date-formatter.provider.ts 100% <100%> (ø) ⬆️
src/modules/day/calendar-day-view.component.ts 95.76% <92.3%> (-0.18%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e7c374...634ccd5. Read the comment docs.

@mattlewis92 mattlewis92 merged commit 5cfbfc7 into 0.26 Jul 31, 2018
@mattlewis92 mattlewis92 deleted the week-view-with-times branch July 31, 2018 03:54
@mitjarogl
Copy link

mitjarogl commented Oct 10, 2018

@mattlewis92 Is it possible this kind of multi day view UI on month view (Issue:#758)? Right now events on template are repeating from day to day and it is not clean way to merge them together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants