Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calendarDate Pipe Incorrect for Day View When Using Moment #1396

Closed
JaxonWright opened this issue Jan 21, 2021 · 2 comments · Fixed by #1397
Closed

calendarDate Pipe Incorrect for Day View When Using Moment #1396

JaxonWright opened this issue Jan 21, 2021 · 2 comments · Fixed by #1397
Milestone

Comments

@JaxonWright
Copy link
Collaborator

Describe the bug

When using CalendarMomentDateFormatter as the dateFormatter provider on the CalendarModule, the calendarDate Pipe returns "Friday, 21 January, 2021" instead of "Friday, January 21, 2021".

Minimal reproduction of the problem with instructions

It is reproduced directly in the examples for the library
https://angular-calendar.com/#/moment

Versions

  • @angular/core: 11.1.0
  • angular-calendar: 0.29.0-beta.6
  • Browser name and version: Chrome 87
@matts-bot
Copy link

matts-bot bot commented Jan 21, 2021

Thanks so much for opening an issue! If you'd like me to give priority to answering your issue or would just like to support this project, then please consider sponsoring me

@JaxonWright
Copy link
Collaborator Author

This line right here is the issue:

return this.moment(date).locale(locale).format('dddd, D MMMM, YYYY');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants