Skip to content

Feat/ svelte 5 upgrade #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Conversation

radiium
Copy link
Contributor

@radiium radiium commented Dec 2, 2024

Feat: Upgrade plugin for use in svelte 5 project
and update dependencies

@mattjennings
Copy link
Owner

Thanks for the PR! My only concern is by switching the components to Svelte 5 syntax this enforces a requirement of Svelte 5. Svelte 5 supports Svelte 4 syntax - is it enough to just update the dependencies?

@radiium
Copy link
Contributor Author

radiium commented Jan 10, 2025

Hi!

Thanks for the PR! My only concern is by switching the components to Svelte 5 syntax this enforces a requirement of Svelte 5. Svelte 5 supports Svelte 4 syntax - is it enough to just update the dependencies?

It seems to me that I encountered problems or just warnings. I didn't look further...

And indeed, I didn't consider backward compatibility in this way. I was thinking more about like this:
v0.4.1 => svelte v3 || v4
v0.5.0 => svelte v5

What do you want to do?

@mattjennings
Copy link
Owner

Ah okay - fair enough, that's probably fine on second thought. I'll merge this in and release it, thank you!

@mattjennings mattjennings merged commit 532b5c7 into mattjennings:main Jan 10, 2025
@radiium
Copy link
Contributor Author

radiium commented Jan 10, 2025

Ah okay - fair enough, that's probably fine on second thought. I'll merge this in and release it, thank you!

Ok great! And thanks for the library, it's very useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants