Add warning message when post is rejected

[nathanaelhoun]

Summary

• Send an ephemeral post to the user when his post is rejected,
• The content of the warning post is configurable in config.json,
• README.md updated with gifs.

Ticket Link

Fixes #21

[codecov-commenter]

Codecov Report

Merging #23 into master will decrease coverage by 4.24%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   39.02%   34.78%   -4.25%     
==========================================
  Files           3        3              
  Lines          41       46       +5     
==========================================
  Hits           16       16              
- Misses         22       27       +5     
  Partials        3        3              

Impacted Files	Coverage Δ
server/configuration.go	13.63% <ø> (ø)
server/plugin.go	56.52% <0.00%> (-15.71%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aeb251...f8ad5f9. Read the comment docs.

[hanzei]

Thanks for jumping on this 👍

[hanzei]

🎉

[hanzei]

@nathanaelhoun Heads up that there is a merge conflict

[nathanaelhoun]

@hanzei Thanks for the heads up! This has been fixed :-)

[DHaussermann]

Tested and passed

• Rejected post UI is clear
• Tested on desktop and mobile
• No issues found

LGTM!

[larkox]

LGTM

[mickmister]

It looks like in the post-rejected.gif that the post is still posted, above the ephemeral message. Is this post supposed to be removed from the user's UI after being rejected?

[nathanaelhoun]

@mickmister You are right, I shouldn't have cut the right side of the capture. Should I submit a PR to replace with this one?

The post isn't posted, and it diseappear when reloading / clicking "cancel"

[mickmister]

@nathanaelhoun It would seem that webapp itself displays the Retry - Cancel appears when a given post fails for any reason? This functionality seems fine to me.

Up to you whether you want to create a PR for the gif change :)

[nathanaelhoun]

@mickmister Exactly, the webapp itself provide the Retry - Cancel button, for a post blocked for any reason (at least for network issue, db issue, or rejected by a plugin).

It was already the case before, but the user wasn't able to distinguish this from a network issue: now he knows he has to watch his language ;-)

I know best is the enemy of good, but I want to make the work correctly: I have submitted #29 :D