Skip to content

feat(EVM EE): Move EVM stack in separate struct #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

0xVolosnikov
Copy link
Contributor

Why ❔

Cleaner.

Is this a breaking change?

  • Yes
  • No

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted.

Copy link
Contributor

Benchmark report

Benchmark Symbol Base Eff Head Eff (%) Base Raw Head Raw (%) Base Blake Head Blake (%) Base Bigint Head Bigint (%)
block run_prepared 230,827,800 230,520,604 (-0.13%) 203,548,756 203,241,560 (-0.15%) 159,100 159,100 (+0.00%) 6,183,361 6,183,361 (+0.00%)
precompiles bn254_ecadd 56,558 56,558 (+0.00%) 51,106 51,106 (+0.00%) 0 0 (+0.00%) 1,363 1,363 (+0.00%)
precompiles bn254_ecmul 1,043,321 1,043,321 (+0.00%) 720,377 720,377 (+0.00%) 0 0 (+0.00%) 80,736 80,736 (+0.00%)
precompiles bn254_pairing 86,193,813 86,193,813 (+0.00%) 71,659,329 71,659,329 (+0.00%) 0 0 (+0.00%) 3,633,621 3,633,621 (+0.00%)
precompiles ecrecover 498,861 500,550 (+0.34%) 327,317 328,398 (+0.33%) 0 0 (+0.00%) 42,886 43,038 (+0.35%)
precompiles id 1,282 1,282 (+0.00%) 1,282 1,282 (+0.00%) 0 0 (+0.00%) 0 0 (+0.00%)
precompiles modexp 29,127,612 29,127,612 (+0.00%) 29,127,612 29,127,612 (+0.00%) 0 0 (+0.00%) 0 0 (+0.00%)
precompiles prepare_for_call 5,839 5,839 (+0.00%) 5,839 5,839 (+0.00%) 0 0 (+0.00%) 0 0 (+0.00%)
precompiles process_transaction 87,279,354 87,269,843 (-0.01%) 72,574,074 72,568,039 (-0.01%) 20 20 (+0.00%) 3,676,240 3,675,371 (-0.02%)
precompiles ripemd 8,417 8,417 (+0.00%) 8,417 8,417 (+0.00%) 0 0 (+0.00%) 0 0 (+0.00%)
precompiles run_prepared 87,855,226 87,845,715 (-0.01%) 73,072,506 73,066,471 (-0.01%) 4,860 4,860 (+0.00%) 3,676,240 3,675,371 (-0.02%)
precompiles sha256 13,513 13,513 (+0.00%) 13,513 13,513 (+0.00%) 0 0 (+0.00%) 0 0 (+0.00%)
precompiles verify_and_apply_batch 226,121 225,954 (-0.07%) 192,361 192,194 (-0.09%) 2,110 2,110 (+0.00%) 0 0 (+0.00%)

@shamatar
Copy link
Member

That collides with #66

@0xVolosnikov
Copy link
Contributor Author

@shamatar yep, I guess #66 collides with a lot of stuff. I'll yield to 66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants