Skip to content

chore: address clippy issues for downstream use #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

dutterbutter
Copy link

What ❔

  • Addresses clippy issues

Why ❔

Is this a breaking change?

  • Yes
  • No

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted.

mm-zk
mm-zk previously approved these changes Jun 9, 2025
@dutterbutter dutterbutter enabled auto-merge (squash) June 9, 2025 20:14
@dutterbutter dutterbutter requested a review from mm-zk June 9, 2025 20:15
mm-zk
mm-zk previously approved these changes Jun 10, 2025
Copy link
Contributor

Benchmark report

Benchmark Symbol Base Eff Head Eff (%) Base Raw Head Raw (%) Base Blake Head Blake (%) Base Bigint Head Bigint (%)
block run_prepared 230,827,800 230,751,838 (-0.03%) 203,548,756 203,472,794 (-0.04%) 159,100 159,100 (+0.00%) 6,183,361 6,183,361 (+0.00%)
precompiles bn254_ecadd 56,558 56,558 (+0.00%) 51,106 51,106 (+0.00%) 0 0 (+0.00%) 1,363 1,363 (+0.00%)
precompiles bn254_ecmul 1,043,321 1,043,321 (+0.00%) 720,377 720,377 (+0.00%) 0 0 (+0.00%) 80,736 80,736 (+0.00%)
precompiles bn254_pairing 86,193,813 86,193,813 (+0.00%) 71,659,329 71,659,329 (+0.00%) 0 0 (+0.00%) 3,633,621 3,633,621 (+0.00%)
precompiles ecrecover 496,617 499,667 (+0.61%) 325,425 327,823 (+0.74%) 0 0 (+0.00%) 42,798 42,961 (+0.38%)
precompiles id 1,282 1,282 (+0.00%) 1,282 1,282 (+0.00%) 0 0 (+0.00%) 0 0 (+0.00%)
precompiles modexp 29,127,612 29,127,612 (+0.00%) 29,127,612 29,127,612 (+0.00%) 0 0 (+0.00%) 0 0 (+0.00%)
precompiles prepare_for_call 5,839 5,839 (+0.00%) 5,839 5,839 (+0.00%) 0 0 (+0.00%) 0 0 (+0.00%)
precompiles process_transaction 87,276,989 87,273,611 (-0.00%) 72,572,669 72,570,427 (-0.00%) 20 20 (+0.00%) 3,676,000 3,675,716 (-0.01%)
precompiles ripemd 8,417 8,417 (+0.00%) 8,417 8,417 (+0.00%) 0 0 (+0.00%) 0 0 (+0.00%)
precompiles run_prepared 87,852,861 87,849,483 (-0.00%) 73,071,101 73,068,859 (-0.00%) 4,860 4,860 (+0.00%) 3,676,000 3,675,716 (-0.01%)
precompiles sha256 13,513 13,513 (+0.00%) 13,513 13,513 (+0.00%) 0 0 (+0.00%) 0 0 (+0.00%)
precompiles verify_and_apply_batch 225,396 225,954 (+0.25%) 191,636 192,194 (+0.29%) 2,110 2,110 (+0.00%) 0 0 (+0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants