Skip to content

fix: addresses issue with state diff recording idx #1074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 18, 2025
Merged

Conversation

dutterbutter
Copy link
Collaborator

@dutterbutter dutterbutter commented Jun 12, 2025

What 💻

  • Updates zksync_remove_duplicate_account_access to use the most recent stack entry and check bounds before removal, logging a warning if the index is out of range

Why ✋

Evidence 📷

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

Documentation 📚

Please ensure the following before submitting your PR:

  • Check if these changes affect any documented features or workflows.
  • Update the book if these changes affect any documented features or workflows.

@dutterbutter dutterbutter changed the title fix: resolves issue 1064 fix: addresses issue with state diff recording idx Jun 12, 2025
@dutterbutter dutterbutter marked this pull request as ready for review June 13, 2025 18:30
@dutterbutter dutterbutter requested a review from a team as a code owner June 13, 2025 18:30
@dutterbutter dutterbutter requested a review from popzxc June 13, 2025 18:54
Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a small reproducible example to be used as a test?

@dutterbutter
Copy link
Collaborator Author

Do we have a small reproducible example to be used as a test?

Sorta, we have the confirmation that it resolves the posted issue in #1064 (comment) and the existing test cases pass. However, given this is an edge case and we are still debugging #1073 which depends on these changes, I will move to a draft and follow up with a test.

@dutterbutter dutterbutter marked this pull request as draft June 17, 2025 02:33
@dutterbutter dutterbutter marked this pull request as ready for review June 17, 2025 23:10
@dutterbutter dutterbutter enabled auto-merge (squash) June 17, 2025 23:10
@dutterbutter
Copy link
Collaborator Author

@popzxc updated comment and added unit test for specific use case

@dutterbutter dutterbutter requested a review from popzxc June 17, 2025 23:11
@dutterbutter dutterbutter merged commit 41f3d53 into main Jun 18, 2025
46 of 47 checks passed
@dutterbutter dutterbutter deleted the db/fix-1064 branch June 18, 2025 08:43
@github-project-automation github-project-automation bot moved this from Todo to Done in DevEx squad Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

removal index (is 360) should be < len (is 360)
2 participants