-
Notifications
You must be signed in to change notification settings - Fork 155
fix: addresses issue with state diff recording idx #1074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a small reproducible example to be used as a test?
Sorta, we have the confirmation that it resolves the posted issue in #1064 (comment) and the existing test cases pass. However, given this is an edge case and we are still debugging #1073 which depends on these changes, I will move to a draft and follow up with a test. |
@popzxc updated comment and added unit test for specific use case |
What 💻
zksync_remove_duplicate_account_access
to use the most recent stack entry and check bounds before removal, logging a warning if the index is out of rangeWhy ✋
Evidence 📷
Include screenshots, screen recordings, or
console
output here demonstrating that your changes work as intendedDocumentation 📚
Please ensure the following before submitting your PR: