This repository was archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Enable cache time-based expiry by default #11849
Merged
Merged
Changes from 4 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
f798aba
make using cache expiry the default behavior
H-Shay adbd8ed
newsfragment
H-Shay bdeaf52
update comment
H-Shay 83661c5
newsfragment and update sample config
H-Shay 4eb3e6a
add boolean flag, rename expiry time
H-Shay 652c620
regenerate sample config
H-Shay 6784e1e
requested changes
H-Shay 253edca
Merge branch 'develop' into shay/default_expiry
H-Shay 775cbf7
add note in upgrade notes about changes
H-Shay 6dddbc7
lint
H-Shay 8efac83
renew sample config
H-Shay c86e536
follow config code style
H-Shay 327ea5a
follow config code style
H-Shay 8d06aac
regenerate sample config
H-Shay f37e95f
requested changes
H-Shay 3299583
d'oh! lints
H-Shay 77ac0d7
cleanup v1 header and reword flags
H-Shay 604145a
Merge branch 'develop' into shay/default_expiry
H-Shay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Enable cache time-based expiry by default. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It may be worth mentioning the new configuration options that are available, or otherwise pointing to the relevant section of the sample config for the full details. This could also be done via our upgrading docs, where we have more room. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would likely still sneak a keyword or two in there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.